Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2668233002: Remove code supporting incremental compilation in dart2js (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove code supporting incremental compilation in dart2js R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a78e2e9806352d1c97df64a95350c38040fa2128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -664 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +1 line, -0 lines 0 comments Download
D pkg/compiler/lib/src/cache_strategy.dart View 1 chunk +0 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/closure.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/tasks.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 6 chunks +1 line, -23 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 4 chunks +4 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 6 chunks +3 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 5 chunks +3 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 16 chunks +33 lines, -279 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 4 chunks +0 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 5 chunks +4 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 4 chunks +3 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_adapter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 3 chunks +1 line, -10 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 9 chunks +1 line, -16 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 6 chunks +3 lines, -57 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +0 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-01 13:40:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
3 years, 10 months ago (2017-02-01 17:33:48 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-02 08:48:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a78e2e9806352d1c97df64a95350c38040fa2128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698