Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2668233002: Remove code supporting incremental compilation in dart2js (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
index 79eff9ac5d79f63e099f90313b26974df45720af..a5af47cf73f1275340fc00bc650d9ef728756d35 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
@@ -232,9 +232,8 @@ class ProgramBuilder {
js.Statement _buildInvokeMain() {
if (_compiler.isMockCompilation) return js.js.comment("Mock compilation");
- MainCallStubGenerator generator = new MainCallStubGenerator(
- backend, backend.emitter,
- hasIncrementalSupport: _compiler.options.hasIncrementalSupport);
+ MainCallStubGenerator generator =
+ new MainCallStubGenerator(backend, backend.emitter);
return generator.generateInvokeMain(_compiler.mainFunction);
}
@@ -492,23 +491,6 @@ class ProgramBuilder {
library, uri, statics, classes, staticFieldsForReflection);
}
- /// HACK for Incremental Compilation.
- ///
- /// Returns a class that contains the fields of a class.
- Class buildFieldsHackForIncrementalCompilation(ClassElement element) {
- assert(_compiler.options.hasIncrementalSupport);
-
- List<Field> instanceFields = _buildFields(element, false);
- js.Name name = namer.className(element);
-
- return new Class(
- element, name, null, [], instanceFields, [], [], [], [], [], [], null,
- isDirectlyInstantiated: true,
- hasRtiField: backend.classNeedsRtiField(element),
- onlyForRti: false,
- isNative: backend.isNative(element));
- }
-
Class _buildClass(ClassElement element) {
bool onlyForRti = collector.classesOnlyNeededForRti.contains(element);
bool hasRtiField = backend.classNeedsRtiField(element);
@@ -673,10 +655,7 @@ class ProgramBuilder {
}
bool _methodCanBeReflected(FunctionElement method) {
- return backend.isAccessibleByReflection(method) ||
- // During incremental compilation, we have to assume that reflection
- // *might* get enabled.
- _compiler.options.hasIncrementalSupport;
+ return backend.isAccessibleByReflection(method);
}
bool _methodCanBeApplied(FunctionElement method) {
@@ -684,16 +663,6 @@ class ProgramBuilder {
closedWorld.getMightBePassedToApply(method);
}
- // TODO(herhut): Refactor incremental compilation and remove method.
- Method buildMethodHackForIncrementalCompilation(FunctionElement element) {
- assert(_compiler.options.hasIncrementalSupport);
- if (element.isInstanceMember) {
- return _buildMethod(element);
- } else {
- return _buildStaticMethod(element);
- }
- }
-
/* Map | List */ _computeParameterDefaultValues(FunctionSignature signature) {
var /* Map | List */ optionalParameterDefaultValues;
if (signature.optionalParametersAreNamed) {

Powered by Google App Engine
This is Rietveld 408576698