Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: pkg/compiler/lib/src/js_backend/enqueuer.dart

Issue 2668233002: Remove code supporting incremental compilation in dart2js (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/enqueuer.dart
diff --git a/pkg/compiler/lib/src/js_backend/enqueuer.dart b/pkg/compiler/lib/src/js_backend/enqueuer.dart
index d907eefb201dfcebf156393b156db5c786e5c504..64e84134991c20ce78eb5a703f68f8a4e30d2aad 100644
--- a/pkg/compiler/lib/src/js_backend/enqueuer.dart
+++ b/pkg/compiler/lib/src/js_backend/enqueuer.dart
@@ -6,13 +6,11 @@ library dart2js.js.enqueue;
import 'dart:collection' show Queue;
-import '../cache_strategy.dart' show CacheStrategy;
import '../common/backend_api.dart' show Backend;
import '../common/codegen.dart' show CodegenWorkItem;
import '../common/tasks.dart' show CompilerTask;
import '../common/work.dart' show WorkItem;
import '../common.dart';
-import '../compiler.dart' show Compiler;
import '../elements/resolution_types.dart'
show ResolutionDartType, ResolutionInterfaceType;
import '../elements/elements.dart' show MemberElement, TypedElement;
@@ -51,20 +49,14 @@ class CodegenEnqueuer extends EnqueuerImpl {
/// All declaration elements that have been processed by codegen.
final Set<Entity> _processedEntities = new Set<Entity>();
- final Set<Entity> newlyEnqueuedElements;
-
- final Set<DynamicUse> newlySeenSelectors;
-
static const ImpactUseCase IMPACT_USE =
const ImpactUseCase('CodegenEnqueuer');
- CodegenEnqueuer(this.task, CacheStrategy cacheStrategy, Backend backend,
- CompilerOptions options, this.strategy)
+ CodegenEnqueuer(
+ this.task, Backend backend, CompilerOptions options, this.strategy)
: _universe =
new CodegenWorldBuilderImpl(backend, const TypeMaskStrategy()),
_workItemBuilder = new CodegenWorkItemBuilder(backend, options),
- newlyEnqueuedElements = cacheStrategy.newSet(),
- newlySeenSelectors = cacheStrategy.newSet(),
nativeEnqueuer = backend.nativeCodegenEnqueuer(),
this._backend = backend,
this._options = options,
@@ -87,10 +79,6 @@ class CodegenEnqueuer extends EnqueuerImpl {
WorkItem workItem = _workItemBuilder.createWorkItem(entity);
if (workItem == null) return;
- if (_options.hasIncrementalSupport) {
- newlyEnqueuedElements.add(entity);
- }
-
if (queueIsClosed) {
throw new SpannableAssertionFailure(
entity, "Codegen work list is closed. Trying to add $entity");
@@ -162,11 +150,7 @@ class CodegenEnqueuer extends EnqueuerImpl {
void processDynamicUse(DynamicUse dynamicUse) {
task.measure(() {
- if (_universe.registerDynamicUse(dynamicUse, _applyMemberUse)) {
- if (_options.hasIncrementalSupport) {
- newlySeenSelectors.add(dynamicUse);
- }
- }
+ _universe.registerDynamicUse(dynamicUse, _applyMemberUse);
});
}
@@ -264,11 +248,6 @@ class CodegenEnqueuer extends EnqueuerImpl {
ImpactUseCase get impactUse => IMPACT_USE;
- void forgetEntity(Entity entity, Compiler compiler) {
- _universe.forgetElement(entity, compiler);
- _processedEntities.remove(entity);
- }
-
@override
Iterable<Entity> get processedEntities => _processedEntities;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698