Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: pkg/compiler/lib/src/options.dart

Issue 2668233002: Remove code supporting incremental compilation in dart2js (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/native/enqueue.dart ('k') | pkg/compiler/lib/src/serialization/modelz.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/options.dart
diff --git a/pkg/compiler/lib/src/options.dart b/pkg/compiler/lib/src/options.dart
index 59992f518bb11c388896bec2ddb57e4cd379f687..32589f34fb3cc8f5fad4bf433f11c22ce6a80bab 100644
--- a/pkg/compiler/lib/src/options.dart
+++ b/pkg/compiler/lib/src/options.dart
@@ -160,11 +160,6 @@ class CompilerOptions implements DiagnosticOptions {
/// Whether to generate a source-map file together with the output program.
final bool generateSourceMap;
- /// Whether some values are cached for reuse in incremental compilation.
- /// Incremental compilation allows calling `Compiler.run` more than once
- /// (experimental).
- final bool hasIncrementalSupport;
-
/// URI of the main output if the compiler is generating source maps.
final Uri outputUri;
@@ -280,8 +275,6 @@ class CompilerOptions implements DiagnosticOptions {
generateCodeWithCompileTimeErrors:
_hasOption(options, Flags.generateCodeWithCompileTimeErrors),
generateSourceMap: !_hasOption(options, Flags.noSourceMaps),
- hasIncrementalSupport: _forceIncrementalSupport ||
- _hasOption(options, Flags.incrementalSupport),
outputUri: _extractUriOption(options, '--out='),
platformConfigUri:
_resolvePlatformConfigFromOptions(libraryRoot, options),
@@ -343,7 +336,6 @@ class CompilerOptions implements DiagnosticOptions {
bool enableUserAssertions: false,
bool generateCodeWithCompileTimeErrors: false,
bool generateSourceMap: true,
- bool hasIncrementalSupport: false,
Uri outputUri: null,
Uri platformConfigUri: null,
bool preserveComments: false,
@@ -402,7 +394,7 @@ class CompilerOptions implements DiagnosticOptions {
suppressWarnings: suppressWarnings,
suppressHints: suppressHints,
shownPackageWarnings: shownPackageWarnings,
- disableInlining: disableInlining || hasIncrementalSupport,
+ disableInlining: disableInlining,
disableTypeInference: disableTypeInference,
dumpInfo: dumpInfo,
enableAssertMessage: enableAssertMessage,
@@ -413,7 +405,6 @@ class CompilerOptions implements DiagnosticOptions {
enableUserAssertions: enableUserAssertions,
generateCodeWithCompileTimeErrors: generateCodeWithCompileTimeErrors,
generateSourceMap: generateSourceMap,
- hasIncrementalSupport: hasIncrementalSupport,
outputUri: outputUri,
platformConfigUri: platformConfigUri ??
_resolvePlatformConfig(libraryRoot, null, const []),
@@ -462,7 +453,6 @@ class CompilerOptions implements DiagnosticOptions {
this.enableUserAssertions: false,
this.generateCodeWithCompileTimeErrors: false,
this.generateSourceMap: true,
- this.hasIncrementalSupport: false,
this.outputUri: null,
this.platformConfigUri: null,
this.preserveComments: false,
@@ -518,7 +508,6 @@ class CompilerOptions implements DiagnosticOptions {
enableUserAssertions,
generateCodeWithCompileTimeErrors,
generateSourceMap,
- hasIncrementalSupport,
outputUri,
platformConfigUri,
preserveComments,
@@ -580,8 +569,6 @@ class CompilerOptions implements DiagnosticOptions {
generateCodeWithCompileTimeErrors: generateCodeWithCompileTimeErrors ??
options.generateCodeWithCompileTimeErrors,
generateSourceMap: generateSourceMap ?? options.generateSourceMap,
- hasIncrementalSupport:
- hasIncrementalSupport ?? options.hasIncrementalSupport,
outputUri: outputUri ?? options.outputUri,
platformConfigUri: platformConfigUri ?? options.platformConfigUri,
preserveComments: preserveComments ?? options.preserveComments,
@@ -706,5 +693,3 @@ const String _serverPlatform = "lib/dart_server.platform";
const String _sharedPlatform = "lib/dart_shared.platform";
const String _UNDETERMINED_BUILD_ID = "build number could not be determined";
-const bool _forceIncrementalSupport =
- const bool.fromEnvironment('DART2JS_EXPERIMENTAL_INCREMENTAL_SUPPORT');
« no previous file with comments | « pkg/compiler/lib/src/native/enqueue.dart ('k') | pkg/compiler/lib/src/serialization/modelz.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698