Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2668183003: [LayoutNG] Make NG algorithms non-oilpan. (Closed)

Created:
3 years, 10 months ago by ikilpatrick
Modified:
3 years, 10 months ago
Reviewers:
eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Make NG algorithms non-oilpan. This also deletes NGLegacyBlockLayoutAlgorithm which was left over from having the coordinator and cleans up a bunch of un-used things in NGLayoutAlgorithm. BUG=635619 Review-Url: https://codereview.chromium.org/2668183003 Cr-Commit-Position: refs/heads/master@{#447675} Committed: https://chromium.googlesource.com/chromium/src/+/3a4d2a76410d5606a26578e0ae0be4bec5f32d04

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : .. #

Patch Set 4 : rebase. #

Patch Set 5 : . #

Patch Set 6 : fix win compile #

Patch Set 7 : fix win compile 2? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -208 lines) Patch
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 2 3 4 5 4 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 3 2 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 2 3 4 2 chunks +20 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h View 1 2 3 4 5 6 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc View 1 2 2 chunks +1 line, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 1 2 3 chunks +2 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.cc View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_legacy_block_layout_algorithm.h View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_legacy_block_layout_algorithm.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.h View 1 2 3 4 5 6 2 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc View 1 2 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
ikilpatrick
3 years, 10 months ago (2017-02-01 10:58:16 UTC) #3
eae
LGTM Thank you
3 years, 10 months ago (2017-02-01 17:32:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668183003/60001
3 years, 10 months ago (2017-02-01 20:31:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/203622) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 10 months ago (2017-02-01 20:43:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668183003/110001
3 years, 10 months ago (2017-02-02 01:32:51 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 01:39:29 UTC) #26
Message was sent while issue was closed.
Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/3a4d2a76410d5606a26578e0ae0b...

Powered by Google App Engine
This is Rietveld 408576698