Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2668033003: Run Ozone CrOS tests with X11 platform by default. (Closed)

Created:
3 years, 10 months ago by kylechar
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, rjkroege, sadrul, Tom Anderson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run Ozone CrOS tests with X11 platform by default. Add GN argument ozone_platform="x11" for Ozone CrOS trybots. This will cause tests to run with Ozone X11 instead of Ozone headless unless the Ozone platform is specified at runtime via command line flag. Most tests now pass with Ozone X11, so it's easier to add an extra argument for tests that don't pass. Newly added tests will run with Ozone X11 too. This change will affect the 'linux_chromium_chromeos_ozone_rel_ng' and 'Mojo Chromium' trybots. 'linux_chromium_chromeos_ozone_rel_ng' is the main Ozone CrOS trybot that runs as part of CQ. 'Mojo ChromiumOS' is an FYI bot that is basically a subset of the CQ trybot. Technically this also affects 'Linux ChromiumOS Ozone Builder' but that trybot doesn't run any tests. BUG=664570 Review-Url: https://codereview.chromium.org/2668033003 Cr-Commit-Position: refs/heads/master@{#447757} Committed: https://chromium.googlesource.com/chromium/src/+/53b5ef0706d72a4822ec4317ff65c412f070ce0e

Patch Set 1 #

Patch Set 2 : Switch ozone-platform flags. #

Patch Set 3 : Fix mb_config.pyl formatting. #

Patch Set 4 : Switch flags for Mojo ChromiumOS too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -101 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 1 19 chunks +22 lines, -99 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (18 generated)
kylechar
3 years, 10 months ago (2017-02-01 16:35:11 UTC) #11
Dirk Pranke
lgtm
3 years, 10 months ago (2017-02-02 01:50:41 UTC) #12
kylechar
Thanks! +thomasanderson just as an FYI.
3 years, 10 months ago (2017-02-02 13:46:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668033003/60001
3 years, 10 months ago (2017-02-02 13:47:01 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 13:50:38 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/53b5ef0706d72a4822ec4317ff65...

Powered by Google App Engine
This is Rietveld 408576698