Get mus_ws_unittests working with Ozone X11.

Get mus_ws_unittests working with Ozone X11.

WindowServerTests need a TYPE_UI message loop to work with libevent for
Ozone X11. Luckily, there is already a virtual function in ServiceTest
to create a MessageLoop.

Other Changes:
- Switch mus_ws_unittests to run with Ozone X11
- Add media_service_unittests to CQ trybot instead of FYI trybot.
- Delete tests from FYI trybot that run on CQ trybot.

BUG=664570
Review-Url: https://codereview.chromium.org/2661163006
Cr-Commit-Position: refs/heads/master@{#448049}
Committed: https://chromium.googlesource.com/chromium/src/+/0166803afdf454945171969526a023cb304bb295

[kylechar, 2017-02-02 14:33:25]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-02-02 16:27:05]

Have you made sure the media tests aren't flaky?

https://codereview.chromium.org/2661163006/diff/1/services/ui/ws/window_manag...
File services/ui/ws/window_manager_client_unittest.cc (right):

https://codereview.chromium.org/2661163006/diff/1/services/ui/ws/window_manag...
services/ui/ws/window_manager_client_unittest.cc:359: // TYPE_UI is needed for
platform events coming from libevent.
Is there any harm in doing this every where, not just ozone?

https://codereview.chromium.org/2661163006/diff/1/testing/buildbot/chromium.c...
File testing/buildbot/chromium.chromiumos.json (left):

https://codereview.chromium.org/2661163006/diff/1/testing/buildbot/chromium.c...
testing/buildbot/chromium.chromiumos.json:275: "--ozone-platform=headless"
How come this is no longer needed?

[rjkroege, 2017-02-02 16:38:42]

drive-by comment

https://codereview.chromium.org/2661163006/diff/1/services/ui/ws/window_manag...
File services/ui/ws/window_manager_client_unittest.cc (right):

https://codereview.chromium.org/2661163006/diff/1/services/ui/ws/window_manag...
services/ui/ws/window_manager_client_unittest.cc:359: // TYPE_UI is needed for
platform events coming from libevent.
On 2017/02/02 16:27:05, sky wrote:
> Is there any harm in doing this every where, not just ozone?

There is a possibility of increased flake (see discussion in
https://codereview.chromium.org/2629983002/) if we use it when not necessary.

I have a different nit (that could be addressed with a TODO) that when we should
be so lucky as to have DRM or Wayland builders, this code will needlessly use a
UI message loop yes?

[kylechar, 2017-02-02 18:01:29]

https://codereview.chromium.org/2661163006/diff/1/services/ui/ws/window_manag...
File services/ui/ws/window_manager_client_unittest.cc (right):

https://codereview.chromium.org/2661163006/diff/1/services/ui/ws/window_manag...
services/ui/ws/window_manager_client_unittest.cc:359: // TYPE_UI is needed for
platform events coming from libevent.
On 2017/02/02 16:38:42, rjkroege wrote:
> On 2017/02/02 16:27:05, sky wrote:
> > Is there any harm in doing this every where, not just ozone?
> 
> There is a possibility of increased flake (see discussion in
> https://codereview.chromium.org/2629983002/) if we use it when not necessary.
> 
> I have a different nit (that could be addressed with a TODO) that when we
should
> be so lucky as to have DRM or Wayland builders, this code will needlessly use
a
> UI message loop yes?
> 
> 
>  

rjkroege: Confusingly, this is actually something different. These tests are for
parts of mus-ws process, which is always TYPE_UI (even for Ozone DRM). The Ozone
MessageLoop type stuff we've been discussing is for the GPU process, which only
needs TYPE_UI when running X11.

sky: There shouldn't be any harm in having this always be TYPE_UI. In fact, the
code needs to be able to run with TYPE_UI, so it's probably better? Changed.

https://codereview.chromium.org/2661163006/diff/1/testing/buildbot/chromium.c...
File testing/buildbot/chromium.chromiumos.json (left):

https://codereview.chromium.org/2661163006/diff/1/testing/buildbot/chromium.c...
testing/buildbot/chromium.chromiumos.json:275: "--ozone-platform=headless"
On 2017/02/02 16:27:05, sky wrote:
> How come this is no longer needed?

This patch fixes mus_ws_unittests running with Ozone X11. This arg forced the
test to run with Ozone headless instead of Ozone X11 before, which is no longer
necessary.

https://codereview.chromium.org/2661163006/diff/1/testing/buildbot/chromium.c...
File testing/buildbot/chromium.chromiumos.json (right):

https://codereview.chromium.org/2661163006/diff/1/testing/buildbot/chromium.c...
testing/buildbot/chromium.chromiumos.json:253: "test": "media_service_unittests"
The media_service_unittests have been running on 'Mojo ChromiumOS' FYI trybot
for two months now. There are no failures on media_service_unittests in the
trybot history I can see, although it doesn't go back that far.

https://build.chromium.org/p/chromium.fyi/builders/Mojo%20ChromiumOS?numbuild...

[sky, 2017-02-02 22:30:34]

LGTM

[kylechar, 2017-02-03 14:03:08]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 14:03:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 15:35:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 15:35:59]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kylechar, 2017-02-03 16:56:18]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 16:56:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 18:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 18:59:38]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-02-03 19:04:35]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-02-03 19:05:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 19:35:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486148675460130,
"parent_rev": "230f8e308399900f340cc2254ce2e3aef08fb2d9", "commit_rev":
"0166803afdf454945171969526a023cb304bb295"}

[commit-bot: I haz the power, 2017-02-03 19:36:10]

Description was changed from

==========
Get mus_ws_unittests working with Ozone X11.

WindowServerTests need a TYPE_UI message loop to work with libevent for
Ozone X11. Luckily, there is already a virtual function in ServiceTest
to create a MessageLoop.

Other Changes:
- Switch mus_ws_unittests to run with Ozone X11
- Add media_service_unittests to CQ trybot instead of FYI trybot.
- Delete tests from FYI trybot that run on CQ trybot.

BUG=664570
==========

to

==========
Get mus_ws_unittests working with Ozone X11.

WindowServerTests need a TYPE_UI message loop to work with libevent for
Ozone X11. Luckily, there is already a virtual function in ServiceTest
to create a MessageLoop.

Other Changes:
- Switch mus_ws_unittests to run with Ozone X11
- Add media_service_unittests to CQ trybot instead of FYI trybot.
- Delete tests from FYI trybot that run on CQ trybot.

BUG=664570

Review-Url: https://codereview.chromium.org/2661163006
Cr-Commit-Position: refs/heads/master@{#448049}
Committed:
https://chromium.googlesource.com/chromium/src/+/0166803afdf454945171969526a0...
==========

[commit-bot: I haz the power, 2017-02-03 19:36:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0166803afdf454945171969526a0...