Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2665193002: Fix aura_unittests for Ozone X11. (Closed)

Created:
3 years, 10 months ago by kylechar
Modified:
3 years, 10 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix aura_unittests and view_unittests for Ozone X11. There are assumptions in the code that PlatformWindow::SetBounds() will change PlatformWindow bounds immediately. This isn't quite true with X11, as the operation is async, but we can just assume SetBounds() was successful. This is what WindowTreeHostX11 does. The PlatformWindow will get a ConfigureNotify message with the actual bounds later and if they don't match the requested bounds it will notify the delegate of the new bounds. Also, change Ozone CrOS bot to run aura_unittests and view_unittest with Ozone X11 now that they work. BUG=664570 Review-Url: https://codereview.chromium.org/2665193002 Cr-Commit-Position: refs/heads/master@{#447437} Committed: https://chromium.googlesource.com/chromium/src/+/ff673af0e1005f36546e4503557aceadae0cd093

Patch Set 1 #

Patch Set 2 : Fix view_unittests too. #

Patch Set 3 : Pass initial bounds into X11Window/X11WindowOzone. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -43 lines) Patch
M services/ui/ws/platform_display_default.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/x11/ozone_platform_x11.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ui/platform_window/x11/x11_window.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/platform_window/x11/x11_window.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/platform_window/x11/x11_window_base.h View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M ui/platform_window/x11/x11_window_base.cc View 1 2 6 chunks +40 lines, -27 lines 0 comments Download
M ui/platform_window/x11/x11_window_ozone.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/platform_window/x11/x11_window_ozone.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (13 generated)
kylechar
3 years, 10 months ago (2017-01-31 17:49:18 UTC) #3
sadrul
lgtm
3 years, 10 months ago (2017-01-31 17:51:42 UTC) #4
kylechar
+jam for testing/buildbot/chromium.chromiumos.json
3 years, 10 months ago (2017-01-31 17:59:56 UTC) #6
kylechar
One slight change sadrul, even if the XWindow isn't mapped aura still expects to get ...
3 years, 10 months ago (2017-01-31 19:24:06 UTC) #8
kylechar
On 2017/01/31 19:24:06, kylechar wrote: > One slight change sadrul, even if the XWindow isn't ...
3 years, 10 months ago (2017-01-31 20:09:26 UTC) #9
kylechar
Okay, all fixed. Please take another look sadrul as I've had to touch a couple ...
3 years, 10 months ago (2017-01-31 21:18:13 UTC) #11
sadrul
still lgtm
3 years, 10 months ago (2017-01-31 21:20:36 UTC) #12
kylechar
+sky for testing/* and services/ui/* (for real this time)
3 years, 10 months ago (2017-01-31 21:28:58 UTC) #14
sky
LGTM
3 years, 10 months ago (2017-02-01 00:32:28 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665193002/40001
3 years, 10 months ago (2017-02-01 02:15:38 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 03:33:42 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff673af0e1005f36546e4503557a...

Powered by Google App Engine
This is Rietveld 408576698