Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 2668013003: [Turbofan] Add more integer SIMD operations for ARM. (Closed)

Created:
3 years, 10 months ago by bbudge
Modified:
3 years, 10 months ago
Reviewers:
titzer, martyn.capewell
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Add more integer SIMD operations for ARM. - Adds logical and arithmetic shifts for all integer types. - Adds min and max for all integer types. - Adds saturating add and subtract for small integer types. - Removes lane operations from the MachineOperatorCache. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668013003 Cr-Commit-Position: refs/heads/master@{#43005} Committed: https://chromium.googlesource.com/v8/v8/+/04568c52161afaf71569ba7fe25288c3dbf041cb

Patch Set 1 #

Patch Set 2 : Don't cache lane operators. #

Patch Set 3 : Rebase, fill out ops and tests. #

Patch Set 4 : Fix stubs for non-ARM buiids. #

Total comments: 2

Patch Set 5 : Use InputIntN overloads for 5, 4, 3 bits. #

Patch Set 6 : Rebase, fix shift tests. #

Patch Set 7 : Fix simd opcode masking to fix compile. #

Patch Set 8 : Make opcode masking uniform. #

Patch Set 9 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+809 lines, -116 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 3 4 6 chunks +115 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 2 5 chunks +23 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 2 5 chunks +23 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 4 chunks +32 lines, -0 lines 0 comments Download
M src/compiler/code-generator-impl.h View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 12 chunks +126 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 7 chunks +15 lines, -18 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 9 chunks +49 lines, -50 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 6 chunks +78 lines, -0 lines 0 comments Download
M src/wasm/function-body-decoder.cc View 1 2 3 4 5 6 chunks +78 lines, -12 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 2 3 4 5 7 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 2 3 4 5 6 7 8 22 chunks +249 lines, -23 lines 0 comments Download

Messages

Total messages: 40 (32 generated)
bbudge
This completes the integer SIMD ops as currently defined. I removed the cached extract and ...
3 years, 10 months ago (2017-02-01 22:17:54 UTC) #8
martyn.capewell
https://codereview.chromium.org/2668013003/diff/60001/src/compiler/arm/code-generator-arm.cc File src/compiler/arm/code-generator-arm.cc (right): https://codereview.chromium.org/2668013003/diff/60001/src/compiler/arm/code-generator-arm.cc#newcode1645 src/compiler/arm/code-generator-arm.cc:1645: i.InputInt8(1)); These are at most Int6, as there are ...
3 years, 10 months ago (2017-02-02 16:23:27 UTC) #11
bbudge
https://codereview.chromium.org/2668013003/diff/60001/src/compiler/arm/code-generator-arm.cc File src/compiler/arm/code-generator-arm.cc (right): https://codereview.chromium.org/2668013003/diff/60001/src/compiler/arm/code-generator-arm.cc#newcode1645 src/compiler/arm/code-generator-arm.cc:1645: i.InputInt8(1)); On 2017/02/02 16:23:26, martyn.capewell wrote: > These are ...
3 years, 10 months ago (2017-02-06 18:51:44 UTC) #14
martyn.capewell
lgtm
3 years, 10 months ago (2017-02-07 14:07:46 UTC) #33
bbudge
+Ben for OWNERS
3 years, 10 months ago (2017-02-07 17:12:24 UTC) #34
titzer
On 2017/02/07 17:12:24, bbudge wrote: > +Ben for OWNERS lgtm
3 years, 10 months ago (2017-02-07 17:16:51 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668013003/160001
3 years, 10 months ago (2017-02-07 17:32:01 UTC) #37
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 17:33:47 UTC) #40
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/04568c52161afaf71569ba7fe25288c3dbf...

Powered by Google App Engine
This is Rietveld 408576698