Move platform/graphics/chromium/* to platform/graphics/

Move platform/graphics/chromium/* to platform/graphics/

BUG=303332
R=abarth@chromium.org, schenney@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162052

[Stephen Chennney, 2013-11-13 17:27:32]

We will do this as part of the move from core/platform to platform. We also want
to break up the monolithic graphics directory into smaller parts.

[ckocagil, 2013-11-13 17:44:49]

On 2013/11/13 17:27:32, Stephen Chenney wrote:
> We will do this as part of the move from core/platform to platform. We also
want
> to break up the monolithic graphics directory into smaller parts.

There's a problem I overlooked while uploading this CL. The coding style of
files from chromium/ also needs to be converted from Chromium style to Blink
style. Please keep that in mind if you'd like to commit this. I might work on
the style conversion if there's demand.

[jamesr, 2013-11-14 02:18:34]

On 2013/11/13 17:44:49, ckocagil wrote:
> On 2013/11/13 17:27:32, Stephen Chenney wrote:
> > We will do this as part of the move from core/platform to platform. We also
> want
> > to break up the monolithic graphics directory into smaller parts.
> 
> There's a problem I overlooked while uploading this CL. The coding style of
> files from chromium/ also needs to be converted from Chromium style to Blink
> style. Please keep that in mind if you'd like to commit this. I might work on
> the style conversion if there's demand.

Everything in the blink repo should be in blink style, not chromium style.  This
shouldn't be an issue for this patch.

[ckocagil, 2013-11-14 19:12:44]

On 2013/11/14 02:18:34, jamesr wrote:
> On 2013/11/13 17:44:49, ckocagil wrote:
> > On 2013/11/13 17:27:32, Stephen Chenney wrote:
> > > We will do this as part of the move from core/platform to platform. We
also
> > want
> > > to break up the monolithic graphics directory into smaller parts.
> > 
> > There's a problem I overlooked while uploading this CL. The coding style of
> > files from chromium/ also needs to be converted from Chromium style to Blink
> > style. Please keep that in mind if you'd like to commit this. I might work
on
> > the style conversion if there's demand.
> 
> Everything in the blink repo should be in blink style, not chromium style. 
This
> shouldn't be an issue for this patch.

Ah, you're right.

Stephen, I rebased the patch, can you PTAL?

[Stephen Chennney, 2013-11-14 20:08:32]

There an issue with the CrossProcessFontLoading class that requires a rename and
a move. Otherwise OK. You'll need to run it through the mac bots again.

https://codereview.chromium.org/26679003/diff/213001/Source/core/platform/gra...
File Source/core/platform/graphics/CrossProcessFontLoading.h (right):

https://codereview.chromium.org/26679003/diff/213001/Source/core/platform/gra...
Source/core/platform/graphics/CrossProcessFontLoading.h:72: class
MemoryActivatedFont : public RefCounted<MemoryActivatedFont> {
The file name should match the class name. This also appears to be mac-only, so
should be in a mac subdirectory.

https://codereview.chromium.org/26679003/diff/213001/Source/core/platform/gra...
File Source/core/platform/graphics/CrossProcessFontLoading.mm (right):

https://codereview.chromium.org/26679003/diff/213001/Source/core/platform/gra...
Source/core/platform/graphics/CrossProcessFontLoading.mm:32: #import
<AppKit/NSFont.h>
Definitely needs to be in the mac directory.

[ckocagil, 2013-11-14 20:21:42]

https://codereview.chromium.org/26679003/diff/213001/Source/core/platform/gra...
File Source/core/platform/graphics/CrossProcessFontLoading.h (right):

https://codereview.chromium.org/26679003/diff/213001/Source/core/platform/gra...
Source/core/platform/graphics/CrossProcessFontLoading.h:72: class
MemoryActivatedFont : public RefCounted<MemoryActivatedFont> {
On 2013/11/14 20:08:33, Stephen Chenney wrote:
> The file name should match the class name. This also appears to be mac-only,
so
> should be in a mac subdirectory.

Done. (hopefully I got it right)

[commit-bot: I haz the power, 2013-11-14 21:28:30]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Stephen Chennney, 2013-11-14 21:29:46]

lgtm

[commit-bot: I haz the power, 2013-11-14 21:30:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ckocagil@chromium.org/26679003/93003

[Stephen Chennney, 2013-11-14 21:48:59]

abarth, can we get an lgtm for web?

[abarth-chromium, 2013-11-15 00:12:27]

LGTM  (feel free to TBR me if you're just changing include paths)

[commit-bot: I haz the power, 2013-11-15 01:08:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ckocagil@chromium.org/26679003/93003

[ckocagil, 2013-11-15 01:23:34]

Committed patchset #6 manually as r162052 (presubmit successful).