Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2667393005: Fix crash when "contenteditable" attribute changes (Closed)

Created:
3 years, 10 months ago by Manuel Rego
Modified:
3 years, 10 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when "contenteditable" attribute changes This patch fixes a crash in HTMLElement::attributeChanged(), we were missing a nullptr check as document().frame() can be null in some situations. BUG=687984 TEST=editing/spelling/crash-modifying-contenteditable.html Review-Url: https://codereview.chromium.org/2667393005 Cr-Commit-Position: refs/heads/master@{#447979} Committed: https://chromium.googlesource.com/chromium/src/+/5621cb109071401fc3cc9fc93e70955df0b7ae12

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use testharness.js in the test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html View 1 1 chunk +12 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Manuel Rego
3 years, 10 months ago (2017-02-03 09:22:05 UTC) #2
Xiaocheng
Thanks for the quick fix. The C++ change is fine. Please change the layout test ...
3 years, 10 months ago (2017-02-03 10:04:34 UTC) #3
Manuel Rego
Thank you for the quick review! https://codereview.chromium.org/2667393005/diff/1/third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html File third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html (right): https://codereview.chromium.org/2667393005/diff/1/third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html#newcode1 third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html:1: <!DOCTYPE html> On ...
3 years, 10 months ago (2017-02-03 10:14:39 UTC) #4
Xiaocheng
lgtm https://codereview.chromium.org/2667393005/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html File third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html (right): https://codereview.chromium.org/2667393005/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html#newcode12 third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html:12: <p>The test passes if it doesn't crash (<a ...
3 years, 10 months ago (2017-02-03 10:17:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667393005/20001
3 years, 10 months ago (2017-02-03 10:26:23 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 12:08:29 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5621cb109071401fc3cc9fc93e70...

Powered by Google App Engine
This is Rietveld 408576698