third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html - Issue 2667393005: Fix crash when "contenteditable" attribute changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html

Issue 2667393005: Fix crash when "contenteditable" attribute changes (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Xiaocheng 2017/02/03 10:04:34 Please use w3c testharness so that you don't need Please use w3c testharness so that you don't need to write -expected.txt. The files to include are - ../../resources/testharness.js - ../../resources/testharnessreport.js Manuel Rego 2017/02/03 10:14:39 Actually I forgot to upload the -expected.txt befo Show quoted text On 2017/02/03 10:04:34, Xiaocheng wrote: > Please use w3c testharness so that you don't need to write -expected.txt. > > The files to include are > - ../../resources/testharness.js > - ../../resources/testharnessreport.js Actually I forgot to upload the -expected.txt before, sorry. Good idea to use testharness.js for this kind of tests too. I've uploaded a new version using it
	2 <script>

	3 if (window.testRunner)

	4 testRunner.dumpAsText();

	5

	6 var doc = document.implementation.createDocument("", null);

	7 var div = document.createElement("div");

	8 doc.appendChild(div);

	9 div.setAttribute("contenteditable", "");

	10 </script>

	11 <p>The test passes if it doesn't crash (<a href="crbug.com/687984">bug #687984</ a>).</p>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('j') | no next file with comments »