third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html - Issue 2667393005: Fix crash when "contenteditable" attribute changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/spelling/crash-modifying-contenteditable.html

Issue 2667393005: Fix crash when "contenteditable" attribute changes (Closed)

Patch Set: Use testharness.js in the test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 test(function() {

	6 var doc = document.implementation.createDocument("", null);

	7 var div = document.createElement("div");

	8 doc.appendChild(div);

	9 div.setAttribute("contenteditable", "");

	10 }, "Check change in `contenteditable` attribute.`");

	11 </script>

	12 <p>The test passes if it doesn't crash (<a href="crbug.com/687984">bug #687984</ a>).</p>
	Manuel Rego 2017/02/03 10:14:39 I'm wondering if we should keep or remove this las I'm wondering if we should keep or remove this last line. Xiaocheng 2017/02/03 10:17:40 I don't think it matters, as long as the bug numbe Show quoted text On 2017/02/03 at 10:14:39, Manuel Rego wrote: > I'm wondering if we should keep or remove this last line. I don't think it matters, as long as the bug number is there.
OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('j') | no next file with comments »