Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2667353005: S390: Use macro to declare rx format assember function (Closed)

Created:
3 years, 10 months ago by Sampson
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use S390X_RX_A_OPCODE_LIST macro to declare rx format assembler function BUG= R=jyan@ca.ibm.com, joransiu@ca.ibm.com, bjaideep@ca.ibm.com Review-Url: https://codereview.chromium.org/2667353005 Cr-Commit-Position: refs/heads/master@{#42933} Committed: https://chromium.googlesource.com/v8/v8/+/4675c975677661d73645cafe3e79229c332eb0c8

Patch Set 1 #

Patch Set 2 : declare BC explicitly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -229 lines) Patch
M src/s390/assembler-s390.h View 1 16 chunks +31 lines, -42 lines 0 comments Download
M src/s390/assembler-s390.cc View 23 chunks +0 lines, -180 lines 0 comments Download
M src/s390/constants-s390.h View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Sampson
Please take a look
3 years, 10 months ago (2017-02-02 20:11:36 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-02-02 20:50:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667353005/20001
3 years, 10 months ago (2017-02-03 20:01:20 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 20:26:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4675c975677661d73645cafe3e79229c332...

Powered by Google App Engine
This is Rietveld 408576698