Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 26672003: Remove references to sconsbuild. (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
Reviewers:
Lei Zhang, M-A Ruel
CC:
chromium-reviews, cmp+cc_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

Remove references to sconsbuild. scons hasn't been used in a long time. Also remove support for using make on Mac, it's no longer supported. All bots that were using make on mac are using ninja these days. BUG=305702 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=227778

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -94 lines) Patch
M build/scripts/slave/build_directory.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/scripts/slave/compile.py View 1 2 3 4 8 chunks +4 lines, -87 lines 0 comments Download
M build/scripts/slave/runtest.py View 1 chunk +1 line, -3 lines 0 comments Download
M build/scripts/tools/slaves.py View 1 chunk +1 line, -2 lines 0 comments Download
M depot_tools/presubmit_support.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Nico
7 years, 2 months ago (2013-10-09 17:41:21 UTC) #1
Lei Zhang
lgtm Last time I tried to do this, I failed miserably: https://codereview.chromium.org/7306001/ Tread carefully. https://codereview.chromium.org/26672003/diff/4001/build/scripts/slave/compile.py ...
7 years, 2 months ago (2013-10-09 18:56:37 UTC) #2
Nico
Thanks! I checked http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%282%29/builds/26937/steps/extract_build/logs/stdio , the perf bots use out/Release these days. Yang: I'm going ...
7 years, 2 months ago (2013-10-09 19:21:35 UTC) #3
Lei Zhang
Maybe split of the master change to a separate CL and give the V8 folks ...
7 years, 2 months ago (2013-10-09 19:33:40 UTC) #4
Nico
On 2013/10/09 19:33:40, Lei Zhang wrote: > Maybe split of the master change to a ...
7 years, 2 months ago (2013-10-09 19:36:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26672003/11001
7 years, 2 months ago (2013-10-09 19:37:19 UTC) #6
commit-bot: I haz the power
Presubmit check for 26672003-11001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 2 months ago (2013-10-09 19:40:02 UTC) #7
Nico
maruel: depot_tools/OWNERS stamp please
7 years, 2 months ago (2013-10-09 19:44:25 UTC) #8
M-A Ruel
lgtm
7 years, 2 months ago (2013-10-09 19:46:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26672003/19001
7 years, 2 months ago (2013-10-09 19:47:44 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 19:50:28 UTC) #11
Message was sent while issue was closed.
Change committed as 227778

Powered by Google App Engine
This is Rietveld 408576698