Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 7306001: Revert "Linux: Remove some references to the sconsbuild directory." (Closed)

Created:
9 years, 5 months ago by cmp
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Nicolas Sylvain
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/build
Visibility:
Public.

Description

Revert "Linux: Remove some references to the sconsbuild directory." This will fix dom_perf.py on Linux Perf (2). extract_build.py is still extracting to sconsbuild, so dom_perf.py gets confused and tries to run performance_ui_tests in out/. When it can't find it, we see the classic error in our Buildbot instance of a hanging bot and the rest of the steps aren't run. The scope of this change is actually much bigger than you may expect. We have sconsbuild in many places, and all of those places need to be updated with the following logic: if 'out/Release' exists, use it, otherwise use 'sconsbuild/Release'. This is similar to how runtest.py works (which is why runtest.py + page cyclers + whatever elses use it didn't break with this CL while the other tests did). Once all of the places that determine the build dir on Linux are updated with that logic, we then update the master locations (eg. the memory master has paths that refer to sconsbuild), land those changes, restart those masters, then update extract_build.py to use a new path: out instead of sconsbuild. TBR=thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M scripts/slave/chromium/archive_build_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/chromium/dom_perf.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/chromium/playback_benchmark.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/chromium/sizes.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/slave_utils.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cmp
9 years, 5 months ago (2011-07-04 01:01:39 UTC) #1
cmp
+cc nsylvain I'm imagining a chrome-build-config script with a --build-dir arg which prints the the ...
9 years, 5 months ago (2011-07-04 01:04:35 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 5 months ago (2011-07-04 01:04:46 UTC) #3
Lei Zhang
9 years, 5 months ago (2011-07-06 18:33:10 UTC) #4
LGTM

Thanks for the reverting this. I forgot we're extracting builds to the
sconsbuild directory. I'll try again at some point and do it right next time.

Powered by Google App Engine
This is Rietveld 408576698