Remove references to sconsbuild.

build/scripts/slave/compile.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A tool to build chrome, executed by buildbot.
 
   When this is run, the current directory (cwd) should be the outer build
   directory (e.g., chrome-release/build/).
 
@@ skipping 488 matching lines @@
                                      filter_obj=xcodebuild_filter)
 
   goma_teardown(options, env)
 
   return result
 
 
 def common_make_settings(
     command, options, env, crosstool=None, compiler=None):
   """
-  Sets desirable environment variables and command-line options
-  that are common to the Make and SCons builds. Used on Linux
-  and for the mac make build.
+  Sets desirable environment variables and command-line options that are used
+  in the Make build.
   """
   assert compiler in (None, 'clang', 'goma', 'goma-clang', 'jsonclang')
   maybe_set_official_build_envvars(options, env)
 
   # Don't stop at the first error.
   command.append('-k')
 
   # Set jobs parallelization based on number of cores.
   jobs = os.sysconf('SC_NPROCESSORS_ONLN')
 
@@ skipping 48 matching lines @@
       clang_dir = os.path.join(options.src_dir,
         'third_party', 'llvm-build', 'Release+Asserts', 'bin')
       if options.goma_dir:
         env['PATH'] = ':'.join([options.goma_dir, clang_dir, env['PATH']])
       else:
         env['PATH'] = ':'.join([clang_dir, env['PATH']])
 
     command.append('CC.host=' + env['CC'])
     command.append('CXX.host=' + env['CXX'])
 
-    if chromium_utils.IsMac():
-      # The default process limit on 10.6 is 266 (`sysctl kern.maxprocperuid`),

[Lei Zhang, 2013/10/09 18:56:37]

This seems useful to know. Keep it?

[Nico, 2013/10/09 19:21:35]

This is only true on mac, and this function doesn't run on mac

[Lei Zhang, 2013/10/09 19:33:40]

Ah, right.

-      # and about 100 processes are used by the system. The webkit bindings
-      # generation scripts open a preprocessor child process, so building at
-      # -j100 runs into the process limit. For now, just build with -j50.
-      goma_jobs = 50
-      if options.clobber:
-        # Disable compiles on local machine.  When the goma server-side object
-        # file cache is warm, this can speed up clobber builds by up to 30%.
-        env['GOMA_USE_LOCAL'] = '0'
-      # Temproary hack to try failing fast when the server looks unhealthy.
-      # 30 seconds is chosen because a local compile is almost certainly
-      # faster.
-      # crbug.com/257467
-      env['GOMA_RETRY'] = '0'
-      env['GOMA_COMPILER_PROXY_RPC_TIMEOUT_SECS'] = '30'
-    else:
-      goma_jobs = 50
+    goma_jobs = 50
     if jobs < goma_jobs:
       jobs = goma_jobs
     command.append('-j%d' % jobs)
     return
 
   if compiler == 'clang':
     clang_dir = os.path.join(options.src_dir,
         'third_party', 'llvm-build', 'Release+Asserts', 'bin')
     env['CC'] = os.path.join(clang_dir, 'clang')
     env['CXX'] = os.path.join(clang_dir, 'clang++')
@@ skipping 27 matching lines @@
     working_dir = options.build_dir
   else:
     # If no solution file (i.e. sub-project *.Makefile) is specified, try to
     # build from <build_dir>/Makefile, or if that doesn't exist, from
     # the top-level Makefile.
     if os.path.isfile(os.path.join(options.build_dir, 'Makefile')):
       working_dir = options.build_dir
     else:
       working_dir = options.src_dir
 
-  # Lots of test-execution scripts hard-code 'sconsbuild' as the output
-  # directory.  Accomodate them.
-  # TODO:  remove when build_dir is properly parameterized in tests.
-  sconsbuild = os.path.join(working_dir, 'sconsbuild')
-  if os.path.islink(sconsbuild):
-    if os.readlink(sconsbuild) != 'out':
-      os.remove(sconsbuild)
-  elif os.path.exists(sconsbuild):
-    dead = sconsbuild + '.dead'
-    if os.path.isdir(dead):
-      shutil.rmtree(dead)
-    elif os.path.isfile(dead):
-      os.remove(dead)
-    os.rename(sconsbuild, sconsbuild+'.dead')
-  if not os.path.lexists(sconsbuild):
-    os.symlink('out', sconsbuild)
-
   os.chdir(working_dir)
   common_make_settings(command, options, env, options.crosstool,
       options.compiler)
 
   # V=1 prints the actual executed command
   if options.verbose:
     command.extend(['V=1'])
   command.extend(options.build_args + args)
 
   # Run the build.
@@ skipping 206 matching lines @@
   # TODO(maruel): Remove the shell argument as soon as ninja.exe is in PATH.
   # At the moment of writing, ninja.bat in depot_tools wraps
   # third_party\ninja.exe, which requires shell=True so it is found correctly.
   result = chromium_utils.RunCommand(
       command, env=env, shell=sys.platform=='win32')
 
   goma_teardown(options, env)
   return result
 
 
-def main_scons(options, args):
-  """Interprets options, clobbers object files, and calls scons.
-  """
-  options.build_dir = os.path.abspath(options.build_dir)
-  if options.clobber:
-    print('Removing %s' % options.target_output_dir)
-    chromium_utils.RemoveDirectory(options.target_output_dir)
-
-  os.chdir(options.build_dir)
-
-  if sys.platform == 'win32':
-    command = ['hammer.bat']
-  else:
-    command = ['hammer']
-
-  env = EchoDict(os.environ)
-  if sys.platform == 'linux2':
-    common_make_settings(command, options, env)
-  else:
-    command.extend(['-k'])
-
-  command.extend([
-      # Force scons to always check for dependency changes.
-      '--implicit-deps-changed',
-      '--mode=' + options.target,
-  ])
-
-  # Here's what you can uncomment if you need to see more info
-  # about what the build is doing on a slave:
-  #
-  #   VERBOSE=1 (a setting in our local SCons config) replaces
-  #   the "Compiling ..." and "Linking ..." lines with the
-  #   actual executed command line(s)
-  #
-  #   --debug=explain (a SCons option) will tell you why SCons
-  #   is deciding to rebuild thing (the target doesn't exist,
-  #   which .h file(s) changed, etc.)
-  #
-  #command.extend(['--debug=explain', 'VERBOSE=1'])
-  command.extend(options.build_args + args)
-  env.print_overrides()
-  return chromium_utils.RunCommand(command, env=env)
-
-
 def main_win(options, args):
   """Interprets options, clobbers object files, and calls the build tool.
   """
   # Prefer the version specified in the .sln. When devenv.com is used at the
   # command line to start a build, it doesn't accept sln file from a different
   # version.
   if not options.msvs_version:
     sln = open(os.path.join(options.build_dir, options.solution), 'rU')
     header = sln.readline().strip()
     sln.close()
@@ skipping 184 matching lines @@
   ret = None
   if build_tool == 'xcode':
     ret = os.path.join(src_dir, 'xcodebuild',
         target + ('-iphoneos' if is_iphone else ''))
   elif build_tool in ['make', 'ninja']:
     ret = os.path.join(src_dir, 'out', target)
   elif build_tool == 'make-android':
     ret = os.path.join(src_dir, 'out')
   elif build_tool in ['msvs', 'vs', 'ib']:
     ret = os.path.join(src_dir, 'build', target)
-  elif build_tool == 'scons':
-    ret = os.path.join(src_dir, 'sconsbuild', target)
   else:
     raise NotImplementedError()
   return os.path.abspath(ret)
 
 
 def real_main():
   option_parser = optparse.OptionParser()
   option_parser.add_option('', '--clobber', action='store_true', default=False,
                            help='delete the output directory before compiling')
   option_parser.add_option('', '--clobber-post-fail', action='store_true',
@@ skipping 15 matching lines @@
                            help='name of project to build')
   option_parser.add_option('', '--build-dir', default='build',
                            help='path to directory containing solution and in '
                                 'which the build output will be placed')
   option_parser.add_option('', '--src-dir', default=None,
                            help='path to the root of the source tree')
   option_parser.add_option('', '--mode', default='dev',
                            help='build mode (dev or official) controlling '
                                 'environment variables set during build')
   option_parser.add_option('', '--build-tool', default=None,
-                           help='specify build tool (ib, vs, scons, xcode)')
+                           help='specify build tool (ib, vs, xcode)')
   option_parser.add_option('', '--build-args', action='append', default=[],
                            help='arguments to pass to the build tool')
   option_parser.add_option('', '--compiler', default=None,
                            help='specify alternative compiler (e.g. clang)')
   if chromium_utils.IsWindows():
     # Windows only.
     option_parser.add_option('', '--no-ib', action='store_true', default=False,
                              help='use Visual Studio instead of IncrediBuild')
     option_parser.add_option('', '--msvs_version',
                              help='VisualStudio version to use')
@@ skipping 45 matching lines @@
     else:
       print('Please specify --build-tool.')
       return 1
   else:
     build_tool_map = {
         'ib' : main_win,
         'vs' : main_win,
         'make' : main_make,
         'make-android' : main_make_android,
         'ninja' : main_ninja,
-        'scons' : main_scons,
         'xcode' : main_xcode,
     }
     main = build_tool_map.get(options.build_tool)
     if not main:
       sys.stderr.write('Unknown build tool %s.\n' % repr(options.build_tool))
       return 2
 
   options.target_output_dir = get_target_build_dir(options.build_tool,
       options.src_dir, options.target, 'iphoneos' in args)
   options.clobber = (options.clobber or
       landmines_triggered(options.target_output_dir))
 
   return main(options, args)
 
 
 if '__main__' == __name__:
   sys.exit(real_main())