Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2152)

Unified Diff: chrome/browser/ntp_snippets/download_suggestions_provider.cc

Issue 2667073003: [NTP::Downloads] Do not fetch Offline Pages when their model is loaded. (Closed)
Patch Set: treib@ nit. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ntp_snippets/download_suggestions_provider.cc
diff --git a/chrome/browser/ntp_snippets/download_suggestions_provider.cc b/chrome/browser/ntp_snippets/download_suggestions_provider.cc
index 2b43b4eb9c4f3f1b10eb12df0fca10267a5916ae..c47a54d1b613f1d485a99604d7e93860961d416e 100644
--- a/chrome/browser/ntp_snippets/download_suggestions_provider.cc
+++ b/chrome/browser/ntp_snippets/download_suggestions_provider.cc
@@ -319,7 +319,9 @@ void DownloadSuggestionsProvider::
void DownloadSuggestionsProvider::OfflinePageModelLoaded(
offline_pages::OfflinePageModel* model) {
DCHECK_EQ(offline_page_model_, model);
- AsynchronouslyFetchOfflinePagesDownloads(/*notify=*/true);
+ // Ignored. We issue a fetch in the constructor (or when Downloads Manager is
+ // loaded) and Offline Page model answers asynchronously once it has been
+ // loaded.
}
void DownloadSuggestionsProvider::OfflinePageAdded(
« no previous file with comments | « no previous file | chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698