[Media Router] Convert to use typemaps for media_router.mojom.

[Media Router] Convert to use typemaps for media_router.mojom.

Replaces the type converters in media_router_type_converters.* with
typemaps.

- MediaSink
- MediaRoute
- PresentationConnectionState
- PresentationConnectionCloseReason
- RouteRequestResultCode

BUG=629373
Review-Url: https://codereview.chromium.org/2666873006
Cr-Commit-Position: refs/heads/master@{#450860}
Committed: https://chromium.googlesource.com/chromium/src/+/ab1bf635d077f765c43a498d0b95034e2d564b4b

[imcheng, 2017-02-01 22:14:21]

imcheng@chromium.org changed reviewers:
+ dcheng@chromium.org, mfoltz@chromium.org

[imcheng, 2017-02-01 22:14:22]

dcheng, mfoltz: PTAL at everything, thanks.

[dcheng, 2017-02-01 22:51:09]

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/media_route.h (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/media_route.h:113: MediaSource media_source_ =
MediaSource(MediaSource::Id());
Maybe just give MediaSource a default constructor

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
(right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc:92: "",
true);
Nit: std::string() instead of "".

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_struct_traits.cc (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_struct_traits.cc:72: if (domain)
Why do we null check here but not for |description|

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_struct_traits.cc:118: if
(custom_controller_path)
Ditto: why do we only sometimes check this?

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_struct_traits.h (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_struct_traits.h:246: :
base::make_optional(sink.description());
It's not ideal to do this, since Mojo invokes getters twice during
serialization. Is it possible/does it make sense to just make it Optional on
media_router::MediaSink.

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/route_request_result.cc (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/route_request_result.cc:17:
base::MakeUnique<MediaRoute>(route), presentation_id, "",
It feels weird that we pass this by unique_ptr: should we just pass by reference
directly?

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/route_request_result.cc:25: return
base::MakeUnique<RouteRequestResult>(nullptr, "", error, result_code);
Nit: "" should be std::string() here and above.

[imcheng, 2017-02-02 21:20:37]

Thanks for the review. PTAL.

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/media_route.h (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/media_route.h:113: MediaSource media_source_ =
MediaSource(MediaSource::Id());
On 2017/02/01 22:51:08, dcheng wrote:
> Maybe just give MediaSource a default constructor

Done.

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
(right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc:92: "",
true);
On 2017/02/01 22:51:08, dcheng wrote:
> Nit: std::string() instead of "".

Done.

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_struct_traits.cc (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_struct_traits.cc:72: if (domain)
On 2017/02/01 22:51:08, dcheng wrote:
> Why do we null check here but not for |description|

Done.

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_struct_traits.cc:118: if
(custom_controller_path)
On 2017/02/01 22:51:08, dcheng wrote:
> Ditto: why do we only sometimes check this?

Done. Converted all to do null check.

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_struct_traits.h (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_struct_traits.h:246: :
base::make_optional(sink.description());
On 2017/02/01 22:51:08, dcheng wrote:
> It's not ideal to do this, since Mojo invokes getters twice during
> serialization. Is it possible/does it make sense to just make it Optional on
> media_router::MediaSink.

Done for description and domain. I haven't done it for MediaRoute because we
don't actually serialize them from C++ to Mojo. (We will for MediaSink for an
upcoming project)

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/route_request_result.cc (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/route_request_result.cc:17:
base::MakeUnique<MediaRoute>(route), presentation_id, "",
On 2017/02/01 22:51:08, dcheng wrote:
> It feels weird that we pass this by unique_ptr: should we just pass by
reference
> directly?

I wanted FromSuccess and FromError to invoke the same constructor so it has to
take a MediaRoute ptr.

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/route_request_result.cc:25: return
base::MakeUnique<RouteRequestResult>(nullptr, "", error, result_code);
On 2017/02/01 22:51:08, dcheng wrote:
> Nit: "" should be std::string() here and above.

Done.

[dcheng, 2017-02-05 05:42:55]

mojo lg to me, but I'll wait for mfoltz@ to review before stamping. Sorry for
the delay!

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_struct_traits.h (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_struct_traits.h:246: :
base::make_optional(sink.description());
On 2017/02/02 21:20:37, imcheng wrote:
> On 2017/02/01 22:51:08, dcheng wrote:
> > It's not ideal to do this, since Mojo invokes getters twice during
> > serialization. Is it possible/does it make sense to just make it Optional on
> > media_router::MediaSink.
> 
> Done for description and domain. I haven't done it for MediaRoute because we
> don't actually serialize them from C++ to Mojo. (We will for MediaSink for an
> upcoming project)

OK, please add a NOTREACHED() or something in there to indicate that for now?
Then we can fix it when it's used.

[imcheng, 2017-02-06 20:26:47]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 20:27:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 20:58:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 20:58:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[imcheng, 2017-02-06 23:39:34]

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
File chrome/browser/media/router/mojo/media_router_struct_traits.h (right):

https://codereview.chromium.org/2666873006/diff/40001/chrome/browser/media/ro...
chrome/browser/media/router/mojo/media_router_struct_traits.h:246: :
base::make_optional(sink.description());
On 2017/02/05 05:42:55, dcheng wrote:
> On 2017/02/02 21:20:37, imcheng wrote:
> > On 2017/02/01 22:51:08, dcheng wrote:
> > > It's not ideal to do this, since Mojo invokes getters twice during
> > > serialization. Is it possible/does it make sense to just make it Optional
on
> > > media_router::MediaSink.
> > 
> > Done for description and domain. I haven't done it for MediaRoute because we
> > don't actually serialize them from C++ to Mojo. (We will for MediaSink for
an
> > upcoming project)
> 
> OK, please add a NOTREACHED() or something in there to indicate that for now?
> Then we can fix it when it's used.

Done.

[mark a. foltz, 2017-02-07 00:57:44]

Looks good overall.  Can some validations be added to the typemaps?

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
File chrome/browser/media/router/media_route.h (right):

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:92: MediaRoute();
This should go with the declarations of other ctors.

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:93: void set_media_route_id(const
MediaRoute::Id& media_route_id) {
Is there a reason this can't be a simple struct with public members?  All of the
getters/setters seem to be trivial.  See the TODO above.

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
File chrome/browser/media/router/media_sink.h (right):

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/media_sink.h:70: MediaSink();
Declare with other ctors?

[imcheng, 2017-02-07 01:35:57]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[imcheng, 2017-02-07 01:36:04]

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
File chrome/browser/media/router/media_route.h (right):

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:92: MediaRoute();
On 2017/02/07 00:57:43, mark a. foltz wrote:
> This should go with the declarations of other ctors.

Done.

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:93: void set_media_route_id(const
MediaRoute::Id& media_route_id) {
On 2017/02/07 00:57:43, mark a. foltz wrote:
> Is there a reason this can't be a simple struct with public members?  All of
the
> getters/setters seem to be trivial.  See the TODO above.

In its current state, yes we can turn this into a struct. For the media
controller project, however, I have been thinking about adding a method to
lazily create the associated MediaRouteController, which would require
MediaRoute to be a class again. So I wanted to see if that design makes sense
before committing to making this a struct.

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
File chrome/browser/media/router/media_sink.h (right):

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/media_sink.h:70: MediaSink();
On 2017/02/07 00:57:43, mark a. foltz wrote:
> Declare with other ctors?

Done.

[commit-bot: I haz the power, 2017-02-07 01:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 01:40:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 01:40:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[imcheng, 2017-02-07 19:29:13]

On 2017/02/07 00:57:44, mark a. foltz wrote:
> Looks good overall.  Can some validations be added to the typemaps?
> 

Sorry I missed this comment before. What sort of validations were you thinking
of adding? We can write unit tests for the struct traits.

[mark a. foltz, 2017-02-07 20:02:39]

On 2017/02/07 at 19:29:13, imcheng wrote:
> On 2017/02/07 00:57:44, mark a. foltz wrote:
> > Looks good overall.  Can some validations be added to the typemaps?
> > 
> 
> Sorry I missed this comment before. What sort of validations were you thinking
of adding? We can write unit tests for the struct traits.

Well, route ids and sink ids aren't allowed to be empty.  There are surely other
constraints on the values passed from the MRPM.

[mark a. foltz, 2017-02-07 20:02:48]

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
File chrome/browser/media/router/media_route.h (right):

https://codereview.chromium.org/2666873006/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:93: void set_media_route_id(const
MediaRoute::Id& media_route_id) {
On 2017/02/07 at 01:36:04, imcheng wrote:
> On 2017/02/07 00:57:43, mark a. foltz wrote:
> > Is there a reason this can't be a simple struct with public members?  All of
the
> > getters/setters seem to be trivial.  See the TODO above.
> 
> In its current state, yes we can turn this into a struct. For the media
controller project, however, I have been thinking about adding a method to
lazily create the associated MediaRouteController, which would require
MediaRoute to be a class again. So I wanted to see if that design makes sense
before committing to making this a struct.

OK.   That will require rethinking the Media Router API, since MediaRoute is
currently a value object that can be freely copied as it's passed to and from
the API.

https://codereview.chromium.org/2666873006/diff/180001/chrome/browser/media/r...
File chrome/browser/media/router/media_sink.h (right):

https://codereview.chromium.org/2666873006/diff/180001/chrome/browser/media/r...
chrome/browser/media/router/media_sink.h:71: // Used by Mojo.
I don't think this comment is necessary.

https://codereview.chromium.org/2666873006/diff/180001/chrome/browser/media/r...
File chrome/browser/media/router/media_source.h (right):

https://codereview.chromium.org/2666873006/diff/180001/chrome/browser/media/r...
chrome/browser/media/router/media_source.h:49: // Used by Mojo.
Please declare with other ctors.

[imcheng, 2017-02-07 20:36:18]

https://codereview.chromium.org/2666873006/diff/180001/chrome/browser/media/r...
File chrome/browser/media/router/media_sink.h (right):

https://codereview.chromium.org/2666873006/diff/180001/chrome/browser/media/r...
chrome/browser/media/router/media_sink.h:71: // Used by Mojo.
On 2017/02/07 20:02:48, mark a. foltz wrote:
> I don't think this comment is necessary.

Done.

https://codereview.chromium.org/2666873006/diff/180001/chrome/browser/media/r...
File chrome/browser/media/router/media_source.h (right):

https://codereview.chromium.org/2666873006/diff/180001/chrome/browser/media/r...
chrome/browser/media/router/media_source.h:49: // Used by Mojo.
On 2017/02/07 20:02:48, mark a. foltz wrote:
> Please declare with other ctors.

Done.

[mark a. foltz, 2017-02-09 22:53:52]

LGTM with comments addressed.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
File chrome/browser/media/router/media_route.h (right):

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:19: // MediaRoute objects contain the
status and metadata of a routing
Optional to fix: it might be helpful to describe examples of media routes, e.g.

- Casting a tab
- Creating an offscreen presentation via Presentation API
- Casting a website using the Cast SDK via the Presentation API

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:20: // operation. The fields are
immutable and reflect the route status
The comments about immutability need to be removed.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:24: // TODO(mfoltz): Convert to a
simple struct and remove uncommon parameters from
If you are committed to keeping this design, then remove this TODO.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:115: // detail as well as its own
route control features route control features in
"route control features" is duplicated.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/media_route.h:119: // |true| if the route can be
displayed in the UI.
s/UI/media router dialog/

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
File chrome/browser/media/router/media_sink.h (right):

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/media_sink.h:25: // The order must stay in sync with
Add a comment here about also updating struct_traits?

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
File chrome/browser/media/router/media_source.cc (right):

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/media_source.cc:40: MediaSource::MediaSource() {}
Please put this in declaration order.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
File chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
(right):

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc:288: const
mojom::MediaRouteProvider::CreateRouteCallback& cb) {
Can this callback be typemapped?  Same comment applies to JoinRouteCallback,
TerminateRouteCallback.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc:331:
std::vector<MediaRoute> routes;
routes({route}). Or just create the vector in the OnRoutesUpdated call below.

Comment applies throughout the file.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
File chrome/browser/media/router/mojo/media_router_struct_traits.cc (right):

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/mojo/media_router_struct_traits.cc:103:
media_router::MediaSink::Id media_sink_id;
I'm not confident in which parameters are guaranteed to be non-empty in the
current state of the implementation.  But I think it would be worth adding some
sanity-check validations to harden this interface.  Add a TODO?

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
File chrome/browser/media/router/mojo/media_router_struct_traits.h (right):

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/mojo/media_router_struct_traits.h:274: NOTREACHED();
It seems like you've written a typemap anyway; remove this?

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/mojo/media_router_struct_traits.h:331: TERMINATED;
It's unfortunate we have duplicate definitions of PresentationConnectionState in
mojom.  Pending resolution of the ongoing design discussion, we should factor
out a separate mojom for this enum.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/mojo/media_router_struct_traits.h:379: case
content::PRESENTATION_CONNECTION_CLOSE_REASON_WENT_AWAY:
Similar comment applies to PresentationConnectionCloseReason.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
File chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
(right):

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc:157:
MediaRoute media_route("differentRouteId", source2_, "mediaSinkId", "",
Since the route description isn't represented by a base::Optional like the sink
description, the API suggests it's mandatory.  But it looks like we're allowing
an empty description.

Just noting a slight inconsistency in handling optional parameters.

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
File chrome/browser/media/router/route_request_result.cc (right):

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/route_request_result.cc:17:
base::MakeUnique<MediaRoute>(route), presentation_id, std::string(),
It's weird to take a const reference to a MediaRoute and then take ownership by
copying and wrapping in a std::unique_ptr.

Should this class just make a copy?

[dcheng, 2017-02-10 10:30:56]

mojo lgtm

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
File chrome/browser/media/router/mojo/media_router_struct_traits.h (right):

https://codereview.chromium.org/2666873006/diff/200001/chrome/browser/media/r...
chrome/browser/media/router/mojo/media_router_struct_traits.h:274: NOTREACHED();
On 2017/02/09 22:53:52, mark a. foltz wrote:
> It seems like you've written a typemap anyway; remove this?

This was at my request: ideally, we want the mojo getters to be very thin and
just return references to data, which this is not doing. Since this isn't used
ATM (though the typemap requires that it be present), I asked to NOTREACHED()
here so we can fix it up if we start using it.

[imcheng, 2017-02-15 18:19:46]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 18:20:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 19:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 19:09:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[imcheng, 2017-02-15 19:32:33]

The CQ bit was checked by imcheng@chromium.org to run a CQ dry run

[imcheng, 2017-02-15 19:33:14]

imcheng@chromium.org changed reviewers:
+ oshima@chromium.org

[imcheng, 2017-02-15 19:33:15]

+oshima for cast_config_client_media_router.cc

[commit-bot: I haz the power, 2017-02-15 19:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 22:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 22:17:21]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-02-16 02:32:36]

lgtm

[imcheng, 2017-02-16 02:39:20]

The CQ bit was checked by imcheng@chromium.org

[imcheng, 2017-02-16 02:39:21]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2666873006/#ps240001
(title: "Remove DCHECK since tests are hitting the code path")

[commit-bot: I haz the power, 2017-02-16 02:40:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 03:30:11]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1487212760388640,
"parent_rev": "c80d2d2b0fcceac67a16bf6ffb516ba5c0023230", "commit_rev":
"ab1bf635d077f765c43a498d0b95034e2d564b4b"}

[commit-bot: I haz the power, 2017-02-16 03:30:49]

Description was changed from

==========
[Media Router] Convert to use typemaps for media_router.mojom.

Replaces the type converters in media_router_type_converters.* with
typemaps.

- MediaSink
- MediaRoute
- PresentationConnectionState
- PresentationConnectionCloseReason
- RouteRequestResultCode

BUG=629373
==========

to

==========
[Media Router] Convert to use typemaps for media_router.mojom.

Replaces the type converters in media_router_type_converters.* with
typemaps.

- MediaSink
- MediaRoute
- PresentationConnectionState
- PresentationConnectionCloseReason
- RouteRequestResultCode

BUG=629373

Review-Url: https://codereview.chromium.org/2666873006
Cr-Commit-Position: refs/heads/master@{#450860}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab1bf635d077f765c43a498d0b95...
==========

[commit-bot: I haz the power, 2017-02-16 03:30:51]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/ab1bf635d077f765c43a498d0b95...