[Media Router] Convert to use typemaps for media_router.mojom.

chrome/browser/media/router/media_route.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTE_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTE_H_
 
 #include <string>
 
 #include "base/containers/small_map.h"
@@ skipping 70 matching lines @@
   // Set to |true| if the presentation associated with this route is an
   // offscreen presentation.
   void set_offscreen_presentation(bool is_offscreen_presentation) {
     is_offscreen_presentation_ = is_offscreen_presentation;
   }
 
   bool is_offscreen_presentation() const { return is_offscreen_presentation_; }
 
   bool Equals(const MediaRoute& other) const;
 
+  // Used by Mojo.
+  MediaRoute();

[mark a. foltz, 2017/02/07 00:57:43]

This should go with the declarations of other ctors.

[imcheng, 2017/02/07 01:36:04]

Done.

+  void set_media_route_id(const MediaRoute::Id& media_route_id) {

[mark a. foltz, 2017/02/07 00:57:43]

Is there a reason this can't be a simple struct with public members?  All of the
getters/setters seem to be trivial.  See the TODO above.

[imcheng, 2017/02/07 01:36:04]

In its current state, yes we can turn this into a struct. For the media
controller project, however, I have been thinking about adding a method to
lazily create the associated MediaRouteController, which would require
MediaRoute to be a class again. So I wanted to see if that design makes sense
before committing to making this a struct.

[mark a. foltz, 2017/02/07 20:02:48]

OK.   That will require rethinking the Media Router API, since MediaRoute is
currently a value object that can be freely copied as it's passed to and from
the API.

+    media_route_id_ = media_route_id;
+  }
+  void set_media_source(const MediaSource& media_source) {
+    media_source_ = media_source;
+  }
+  void set_media_sink_id(const MediaSink::Id& media_sink_id) {
+    media_sink_id_ = media_sink_id;
+  }
+  void set_description(const std::string& description) {
+    description_ = description;
+  }
+  void set_local(bool is_local) { is_local_ = is_local; }
+  void set_custom_controller_path(const std::string& custom_controller_path) {
+    custom_controller_path_ = custom_controller_path;
+  }
+  void set_for_display(bool for_display) { for_display_ = for_display; }
+
  private:
   MediaRoute::Id media_route_id_;
   MediaSource media_source_;
   MediaSink::Id media_sink_id_;
   std::string description_;
-  bool is_local_;
+  bool is_local_ = false;
   std::string custom_controller_path_;
-  bool for_display_;
-  bool is_incognito_;
-  bool is_offscreen_presentation_;
+  bool for_display_ = false;
+  bool is_incognito_ = false;
+  bool is_offscreen_presentation_ = false;
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTE_H_