Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: chrome/browser/media/router/route_request_result.h

Issue 2666873006: [Media Router] Convert to use typemaps for media_router.mojom. (Closed)
Patch Set: Remove DCHECK since tests are hitting the code path Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/route_request_result.h
diff --git a/chrome/browser/media/router/route_request_result.h b/chrome/browser/media/router/route_request_result.h
index c953a72897a45d0884f47c651662490512dda483..81e820035b017c656f9a7fd7650757c34b1040b9 100644
--- a/chrome/browser/media/router/route_request_result.h
+++ b/chrome/browser/media/router/route_request_result.h
@@ -52,10 +52,14 @@ class RouteRequestResult {
};
static std::unique_ptr<RouteRequestResult> FromSuccess(
- std::unique_ptr<MediaRoute> route,
+ const MediaRoute& route,
const std::string& presentation_id);
static std::unique_ptr<RouteRequestResult> FromError(const std::string& error,
ResultCode result_code);
+ RouteRequestResult(std::unique_ptr<MediaRoute> route,
+ const std::string& presentation_id,
+ const std::string& error,
+ ResultCode result_code);
~RouteRequestResult();
@@ -68,11 +72,6 @@ class RouteRequestResult {
ResultCode result_code() const { return result_code_; }
private:
- RouteRequestResult(std::unique_ptr<MediaRoute> route,
- const std::string& presentation_id,
- const std::string& error,
- ResultCode result_code);
-
std::unique_ptr<MediaRoute> route_;
std::string presentation_id_;
GURL presentation_url_;

Powered by Google App Engine
This is Rietveld 408576698