Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2666833003: Revert of Removing "All Bookmarks" (Closed)

Created:
3 years, 10 months ago by gchatz
Modified:
3 years, 10 months ago
CC:
chromium-reviews, tfarina, pkl (ping after 24h if needed), noyau+watch_chromium.org, arv+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Removing "All Bookmarks" (patchset #3 id:40001 of https://codereview.chromium.org/2662473003/ ) Reason for revert: Many bookmarks EG tests failed (like BookmarksTestCase.testDeleteParentFolder) with following error: 2017-01-31 09:41:25.353 ios_chrome_ui_egtests[21921:177122] +[BookmarkHomeHandsetViewController setEditing:animated:]: unrecognized selector sent to class 0x111012ad0 2017-01-31 09:41:25.391 ios_chrome_ui_egtests[21921:177122] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '+[BookmarkHomeHandsetViewController setEditing:animated:]: unrecognized selector sent to class 0x111012ad0' Original issue's description: > Removing "All Bookmarks" > > Removing the flag from experimental settings and all the code supporting the feature. > > BUG=338334 > TEST=Make a pass at bookmarks making sure nothing is broken. > > Review-Url: https://codereview.chromium.org/2662473003 > Cr-Commit-Position: refs/heads/master@{#447251} > Committed: https://chromium.googlesource.com/chromium/src/+/acb696d91f1a59f6cb2f5d68fcd2d4f0886caffd TBR=stkhapugin@chromium.org,noyau@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=338334 Review-Url: https://codereview.chromium.org/2666833003 Cr-Commit-Position: refs/heads/master@{#447334} Committed: https://chromium.googlesource.com/chromium/src/+/6de347c2112ff05158f32c76547ad7fe37197fe4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -17 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/about_flags.mm View 1 chunk +9 lines, -0 lines 0 comments Download
M ios/chrome/browser/chrome_switches.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/chrome_switches.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +19 lines, -0 lines 0 comments Download
M ios/chrome/browser/resources/Settings.bundle/Experimental.plist View 1 chunk +22 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm View 1 chunk +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/BUILD.gn View 3 chunks +8 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm View 9 chunks +34 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm View 9 chunks +32 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_menu_item.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_menu_item.mm View 11 chunks +26 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_menu_view.mm View 3 chunks +23 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_position_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_position_cache.mm View 2 chunks +8 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_position_cache_unittest.mm View 1 chunk +10 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm View 2 chunks +8 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm View 1 chunk +18 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm View 3 chunks +14 lines, -2 lines 0 comments Download
A ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_star.png View Binary file 0 comments Download
A ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_star@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/bookmarks/resources/bookmark_blue_star@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_star.png View Binary file 0 comments Download
A ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_star@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/bookmarks/resources/bookmark_gray_star@3x.png View Binary file 0 comments Download

Messages

Total messages: 13 (6 generated)
gchatz
Created Revert of Removing "All Bookmarks"
3 years, 10 months ago (2017-01-31 20:59:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666833003/1
3 years, 10 months ago (2017-01-31 21:00:09 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-01-31 21:00:11 UTC) #5
kkhorimoto
lgtm
3 years, 10 months ago (2017-01-31 21:00:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666833003/1
3 years, 10 months ago (2017-01-31 21:30:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6de347c2112ff05158f32c76547ad7fe37197fe4
3 years, 10 months ago (2017-01-31 21:33:15 UTC) #12
noyau (Ping after 24h)
3 years, 10 months ago (2017-02-01 10:29:34 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698