Chromium Code Reviews
DescriptionRevert of Removing "All Bookmarks" (patchset #3 id:40001 of https://codereview.chromium.org/2662473003/ )
Reason for revert:
Many bookmarks EG tests failed (like BookmarksTestCase.testDeleteParentFolder) with following error:
2017-01-31 09:41:25.353 ios_chrome_ui_egtests[21921:177122] +[BookmarkHomeHandsetViewController setEditing:animated:]: unrecognized selector sent to class 0x111012ad0
2017-01-31 09:41:25.391 ios_chrome_ui_egtests[21921:177122] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '+[BookmarkHomeHandsetViewController setEditing:animated:]: unrecognized selector sent to class 0x111012ad0'
Original issue's description:
> Removing "All Bookmarks"
>
> Removing the flag from experimental settings and all the code supporting the feature.
>
> BUG=338334
> TEST=Make a pass at bookmarks making sure nothing is broken.
>
> Review-Url: https://codereview.chromium.org/2662473003
> Cr-Commit-Position: refs/heads/master@{#447251}
> Committed: https://chromium.googlesource.com/chromium/src/+/acb696d91f1a59f6cb2f5d68fcd2d4f0886caffd
TBR=stkhapugin@chromium.org,noyau@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=338334
Review-Url: https://codereview.chromium.org/2666833003
Cr-Commit-Position: refs/heads/master@{#447334}
Committed: https://chromium.googlesource.com/chromium/src/+/6de347c2112ff05158f32c76547ad7fe37197fe4
Patch Set 1 #Messages
Total messages: 13 (6 generated)
|