Removing "All Bookmarks"

Removing "All Bookmarks"

Removing the flag from experimental settings and all the code supporting the feature.

BUG=338334
TEST=Make a pass at bookmarks making sure nothing is broken.

Review-Url: https://codereview.chromium.org/2662473003
Cr-Commit-Position: refs/heads/master@{#447251}
Committed: https://chromium.googlesource.com/chromium/src/+/acb696d91f1a59f6cb2f5d68fcd2d4f0886caffd

[noyau (Ping after 24h), 2017-01-27 14:07:50]

The CQ bit was checked by noyau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 14:08:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 14:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 14:09:49]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[noyau (Ping after 24h), 2017-01-31 12:24:50]

The CQ bit was checked by noyau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 12:24:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[noyau (Ping after 24h), 2017-01-31 12:58:44]

noyau@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[stkhapugin, 2017-01-31 13:05:00]

lgtm with a comment. Also please change the CL description to reflect on what
happened to All Bookmarks, because you are not only removing the flag, you're
removing the "feature".

https://codereview.chromium.org/2662473003/diff/20001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm (right):

https://codereview.chromium.org/2662473003/diff/20001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm:188:
BookmarkMenuItem* outItem;
= nil

[commit-bot: I haz the power, 2017-01-31 13:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 13:41:26]

Dry run: This issue passed the CQ dry run.

[noyau (Ping after 24h), 2017-01-31 15:55:08]

Description was changed from

==========
Removing "All Bookmarks" flags from experimental settings

BUG=338334
TEST=Make a pass at bookmarks making sure nothing is broken.
==========

to

==========
Removing "All Bookmarks"

Removing the flag from experimental settings and all the code supporting the
feature.

BUG=338334
TEST=Make a pass at bookmarks making sure nothing is broken.
==========

[noyau (Ping after 24h), 2017-01-31 15:56:33]

The CQ bit was checked by noyau@chromium.org

[noyau (Ping after 24h), 2017-01-31 15:56:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2662473003/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2017-01-31 15:56:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 17:11:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485878193182800,
"parent_rev": "8ff9d153a2aee2f4a7acac6910a97fade45a54c8", "commit_rev":
"acb696d91f1a59f6cb2f5d68fcd2d4f0886caffd"}

[commit-bot: I haz the power, 2017-01-31 17:12:32]

Description was changed from

==========
Removing "All Bookmarks"

Removing the flag from experimental settings and all the code supporting the
feature.

BUG=338334
TEST=Make a pass at bookmarks making sure nothing is broken.
==========

to

==========
Removing "All Bookmarks"

Removing the flag from experimental settings and all the code supporting the
feature.

BUG=338334
TEST=Make a pass at bookmarks making sure nothing is broken.

Review-Url: https://codereview.chromium.org/2662473003
Cr-Commit-Position: refs/heads/master@{#447251}
Committed:
https://chromium.googlesource.com/chromium/src/+/acb696d91f1a59f6cb2f5d68fcd2...
==========

[commit-bot: I haz the power, 2017-01-31 17:12:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/acb696d91f1a59f6cb2f5d68fcd2...

[gchatz, 2017-01-31 20:59:35]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2666833003/ by gchatz@chromium.org.

The reason for reverting is: Many bookmarks EG tests failed (like
BookmarksTestCase.testDeleteParentFolder) with following error:
2017-01-31 09:41:25.353 ios_chrome_ui_egtests[21921:177122]
+[BookmarkHomeHandsetViewController setEditing:animated:]: unrecognized selector
sent to class 0x111012ad0
2017-01-31 09:41:25.391 ios_chrome_ui_egtests[21921:177122] *** Terminating app
due to uncaught exception 'NSInvalidArgumentException', reason:
'+[BookmarkHomeHandsetViewController setEditing:animated:]: unrecognized
selector sent to class 0x111012ad0'.

[noyau (Ping after 24h), 2017-02-01 10:31:08]

Darn, sorry.

https://codereview.chromium.org/2662473003/diff/20001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm (right):

https://codereview.chromium.org/2662473003/diff/20001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm:188:
BookmarkMenuItem* outItem;
On 2017/01/31 13:04:59, stkhapugin wrote:
> = nil

Done.