Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm

Issue 2666833003: Revert of Removing "All Bookmarks" (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm b/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm
index d9ec4ef5f88a1dddfd7763591360a72e6b23966b..841affa3125823e4d66996bb0624798e37d441a2 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios_unittest.mm
@@ -178,17 +178,29 @@
}
TEST_F(BookmarkIOSUtilsUnitTest, TestPositionCache) {
- // Try to store and retrieve a cache for the folderMenuItem.
- const BookmarkNode* mobileNode = _bookmarkModel->mobile_node();
- const BookmarkNode* f1 = AddFolder(mobileNode, @"f1");
- BookmarkMenuItem* item =
- [BookmarkMenuItem folderMenuItemForNode:f1 rootAncestor:NULL];
+ // Try to store and retrieve a cache for the allMenuItem.
+ BookmarkMenuItem* item = [BookmarkMenuItem allMenuItem];
CGFloat position = 23;
bookmark_utils_ios::CachePosition(position, item);
- BookmarkMenuItem* outItem = nil;
CGFloat outPosition;
+ BookmarkMenuItem* outItem;
BOOL result = bookmark_utils_ios::GetPositionCache(_bookmarkModel, &outItem,
&outPosition);
+ if (experimental_flags::IsAllBookmarksEnabled()) {
+ ASSERT_TRUE(result);
+ EXPECT_NSEQ(item, outItem);
+ EXPECT_NEAR(position, outPosition, 0.01);
+ } else {
+ ASSERT_FALSE(result);
+ }
+
+ // Try to store and retrieve a cache for the folderMenuItem.
+ const BookmarkNode* mobileNode = _bookmarkModel->mobile_node();
+ const BookmarkNode* f1 = AddFolder(mobileNode, @"f1");
+ item = [BookmarkMenuItem folderMenuItemForNode:f1 rootAncestor:NULL];
+ bookmark_utils_ios::CachePosition(position, item);
+ result = bookmark_utils_ios::GetPositionCache(_bookmarkModel, &outItem,
+ &outPosition);
ASSERT_TRUE(result);
EXPECT_NSEQ(item, outItem);
EXPECT_NEAR(position, outPosition, 0.01);
« no previous file with comments | « ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm ('k') | ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698