API delegate for non-native file systems

API delegate for non-native file systems

The Chrome OS Files app can provide non-native file systems, like
Drive. Unrelated APIs like file_handlers can access files, including
files from non-native FSs. This CL creates NonNativeFileSystemDelegate
to handle queries about non-native FSs, so that the API itself doesn't
have to depend on the FS logic in //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG=679870
Review-Url: https://codereview.chromium.org/2666763005
Cr-Commit-Position: refs/heads/master@{#448499}
Committed: https://chromium.googlesource.com/chromium/src/+/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24

[michaelpg, 2017-02-01 01:09:09]

Description was changed from

==========
Create a delegate for Chrome-specific non-native file systems

The Chrome OS Files app can provide non-native file systems (e.g.,
Drive). Unrelated APIs like file_handlers can access local files,
including files from non-native FSs. This CL creates
NonNativeFileSystemDelegate to handle queries about non-native FSs, so
that the API itself doesn't have to depend on //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG=
==========

to

==========
Create a delegate for Chrome-specific non-native file systems

The Chrome OS Files app can provide non-native file systems (e.g.,
Drive). Unrelated APIs like file_handlers can access local files,
including files from non-native FSs. This CL creates
NonNativeFileSystemDelegate to handle queries about non-native FSs, so
that the API itself doesn't have to depend on //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG=679870
==========

[michaelpg, 2017-02-01 01:09:09]

michaelpg@chromium.org changed reviewers:
+ benwells@chromium.org

[michaelpg, 2017-02-01 01:17:24]

Description was changed from

==========
Create a delegate for Chrome-specific non-native file systems

The Chrome OS Files app can provide non-native file systems (e.g.,
Drive). Unrelated APIs like file_handlers can access local files,
including files from non-native FSs. This CL creates
NonNativeFileSystemDelegate to handle queries about non-native FSs, so
that the API itself doesn't have to depend on //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG=679870
==========

to

==========
Create a delegate for Chrome-specific non-native file systems

The Chrome OS Files app can provide non-native file systems, like
Drive. Unrelated APIs like file_handlers can access files, including
files from non-native FSs. This CL creates NonNativeFileSystemDelegate
to handle queries about non-native FSs, so that the API itself doesn't
have to depend on //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG=679870
==========

[michaelpg, 2017-02-01 01:20:10]

Ben, mind taking a look? A follow-up CL will move the file_handlers API into
//extensions.

[michaelpg, 2017-02-01 03:07:38]

Description was changed from

==========
Create a delegate for Chrome-specific non-native file systems

The Chrome OS Files app can provide non-native file systems, like
Drive. Unrelated APIs like file_handlers can access files, including
files from non-native FSs. This CL creates NonNativeFileSystemDelegate
to handle queries about non-native FSs, so that the API itself doesn't
have to depend on //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG=679870
==========

to

==========
API delegate for non-native file systems

The Chrome OS Files app can provide non-native file systems, like
Drive. Unrelated APIs like file_handlers can access files, including
files from non-native FSs. This CL creates NonNativeFileSystemDelegate
to handle queries about non-native FSs, so that the API itself doesn't
have to depend on the FS logic in //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG=679870
==========

[benwells, 2017-02-03 01:45:51]

On 2017/02/01 01:20:10, michaelpg wrote:
> Ben, mind taking a look? A follow-up CL will move the file_handlers API into
> //extensions.

Sorry about the delay, I'll try to look tonight...

[benwells, 2017-02-04 01:07:19]

Sorry again for the delay. lgtm!

[michaelpg, 2017-02-07 00:10:42]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-02-07 00:10:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2666763005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-07 00:11:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 01:34:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486426242140360,
"parent_rev": "e074ea04adb95ba87ccb22ffea57cf7399949beb", "commit_rev":
"75d89e70f4a7a0a8762239d1e36f4109f2c4fb24"}

[commit-bot: I haz the power, 2017-02-07 01:35:05]

Description was changed from

==========
API delegate for non-native file systems

The Chrome OS Files app can provide non-native file systems, like
Drive. Unrelated APIs like file_handlers can access files, including
files from non-native FSs. This CL creates NonNativeFileSystemDelegate
to handle queries about non-native FSs, so that the API itself doesn't
have to depend on the FS logic in //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG=679870
==========

to

==========
API delegate for non-native file systems

The Chrome OS Files app can provide non-native file systems, like
Drive. Unrelated APIs like file_handlers can access files, including
files from non-native FSs. This CL creates NonNativeFileSystemDelegate
to handle queries about non-native FSs, so that the API itself doesn't
have to depend on the FS logic in //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG=679870

Review-Url: https://codereview.chromium.org/2666763005
Cr-Commit-Position: refs/heads/master@{#448499}
Committed:
https://chromium.googlesource.com/chromium/src/+/75d89e70f4a7a0a8762239d1e36f...
==========

[commit-bot: I haz the power, 2017-02-07 01:35:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/75d89e70f4a7a0a8762239d1e36f...