Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2679693003: . (Closed)

Created:
3 years, 10 months ago by michaelpg
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closing for the tidier crrev.com/2685453002.

Patch Set 1 #

Patch Set 2 : remove unused deps #

Patch Set 3 : Add owners from c/b/extensions/api/file_handlers #

Patch Set 4 : required git cl format #

Patch Set 5 : rejigger deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1328 lines) Patch
M apps/DEPS View 1 1 chunk +0 lines, -4 lines 0 comments Download
M apps/launcher.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/open_util.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/file_handlers/api_file_handler_util_unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/app_file_handler_util.h View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 1 chunk +0 lines, -361 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/directory_util.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/directory_util.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/directory_util_unittest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/mime_util.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/mime_util.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/DEPS View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A extensions/browser/api/file_handlers/BUILD.gn View 1 1 chunk +14 lines, -0 lines 0 comments Download
A extensions/browser/api/file_handlers/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/api/file_handlers/app_file_handler_util.h View 6 chunks +10 lines, -7 lines 0 comments Download
A + extensions/browser/api/file_handlers/app_file_handler_util.cc View 1 2 3 7 chunks +12 lines, -14 lines 0 comments Download
A + extensions/browser/api/file_handlers/app_file_handler_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/file_handlers/directory_util.h View 5 chunks +8 lines, -6 lines 0 comments Download
A + extensions/browser/api/file_handlers/directory_util.cc View 4 chunks +8 lines, -8 lines 0 comments Download
A + extensions/browser/api/file_handlers/directory_util_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/api/file_handlers/mime_util.h View 6 chunks +9 lines, -7 lines 0 comments Download
A + extensions/browser/api/file_handlers/mime_util.cc View 1 2 3 6 chunks +21 lines, -37 lines 0 comments Download
A + extensions/browser/api/file_handlers/mime_util_unittest.cc View 1 2 3 7 chunks +17 lines, -20 lines 0 comments Download

Depends on Patchset:

Issue 2666763005 Patch 40001

Messages

Total messages: 4 (4 generated)
michaelpg
Description was changed from ========== Move file_handlers API from //chrome to //extensions Results in removing ...
3 years, 10 months ago (2017-02-07 00:56:21 UTC) #1
michaelpg
michaelpg@chromium.org changed reviewers: + benwells@chromium.org, mtomasz@chromium.org, tzik@chromium.org
3 years, 10 months ago (2017-02-07 00:56:21 UTC) #2
michaelpg
Description was changed from ========== Move file_handlers API from //chrome to //extensions Largely mechanical CL ...
3 years, 10 months ago (2017-02-07 01:21:21 UTC) #3
michaelpg
3 years, 10 months ago (2017-02-07 01:21:21 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698