Move file_handlers API from //chrome to //extensions

Move file_handlers API from //chrome to //extensions

Largely mechanical CL via move_source_file.py, subbing some Profile usage
for BrowserContext.

Results in removing some DEPS exceptions and #includes from //apps.

BUG=679870
Review-Url: https://codereview.chromium.org/2685453002
Cr-Original-Commit-Position: refs/heads/master@{#449460}
Committed: https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f8582db517846799
Review-Url: https://codereview.chromium.org/2685453002
Cr-Commit-Position: refs/heads/master@{#450144}
Committed: https://chromium.googlesource.com/chromium/src/+/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef

[michaelpg, 2017-02-07 01:20:35]

michaelpg@chromium.org changed reviewers:
+ benwells@chromium.org, mtomasz@chromium.org, tzik@chromium.org

[michaelpg, 2017-02-07 01:20:35]

michaelpg@chromium.org changed required reviewers:
+ benwells@chromium.org, mtomasz@chromium.org, tzik@chromium.org

[michaelpg, 2017-02-07 01:20:37]

PTAL.

mtomasz:
  chrome/browser/chromeos/extensions/file_manager/
  chrome/browser/chromeos/file_manager/
  chrome/browser/chromeos/fileapi/external_file_url_request_job.cc
  chrome/browser/extensions/api/file_system/file_system_api.cc

tzik:
  OWNER permission to target storage/common/fileapi
  same for storage/browser/fileapi (moved dep one level deeper, so it's
    weird that requires approval)

benwells: everything else

[mtomasz, 2017-02-07 01:41:35]

lgtm for my partk

[tzik, 2017-02-07 06:32:21]

lgtm

[benwells, 2017-02-07 07:20:38]

nice! lgtm

https://codereview.chromium.org/2685453002/diff/1/extensions/browser/api/file...
File extensions/browser/api/file_handlers/app_file_handler_util.h (right):

https://codereview.chromium.org/2685453002/diff/1/extensions/browser/api/file...
extensions/browser/api/file_handlers/app_file_handler_util.h:27: //
TODO(michaelpg,benwells): move this to an app-specific namespace and
If this TODO doesn't make sense any more feel free to remove it.

[michaelpg, 2017-02-07 13:21:16]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-02-07 13:21:16]

The CQ bit was unchecked by michaelpg@chromium.org

[michaelpg, 2017-02-07 23:47:08]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-02-07 23:47:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
mtomasz@chromium.org, benwells@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2685453002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-07 23:48:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:34:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:34:23]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2017-02-08 20:53:41]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-02-08 20:53:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
mtomasz@chromium.org, benwells@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2685453002/#ps40001
(title: "revert file_system_api.h dependency")

[commit-bot: I haz the power, 2017-02-08 20:54:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 21:35:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:35:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2017-02-08 23:53:49]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-02-08 23:53:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
mtomasz@chromium.org, benwells@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2685453002/#ps60001
(title: "ExtensionsAPIClient in unittest")

[commit-bot: I haz the power, 2017-02-08 23:54:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 01:07:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 01:07:04]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[michaelpg, 2017-02-09 22:10:54]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-02-09 22:10:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mtomasz@chromium.org, benwells@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2685453002/#ps80001
(title: "size_t/int conflict")

[commit-bot: I haz the power, 2017-02-09 22:11:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 23:23:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486678254076850,
"parent_rev": "6afbfbed2eaf271b5cf9f5be9dec100f37b98a2f", "commit_rev":
"10d5e4e8430e41ca148452f2f8582db517846799"}

[commit-bot: I haz the power, 2017-02-09 23:24:29]

Description was changed from

==========
Move file_handlers API from //chrome to //extensions

Largely mechanical CL via move_source_file.py, subbing some Profile usage
for BrowserContext.

Results in removing some DEPS exceptions and #includes from //apps.

BUG=679870
==========

to

==========
Move file_handlers API from //chrome to //extensions

Largely mechanical CL via move_source_file.py, subbing some Profile usage
for BrowserContext.

Results in removing some DEPS exceptions and #includes from //apps.

BUG=679870

Review-Url: https://codereview.chromium.org/2685453002
Cr-Commit-Position: refs/heads/master@{#449460}
Committed:
https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f858...
==========

[commit-bot: I haz the power, 2017-02-09 23:24:30]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f858...

[Bret, 2017-02-09 23:41:22]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2685883008/ by bsep@chromium.org.

The reason for reverting is: Broke compile on Linux x64. Example failure:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...

The build error is kind of confusing to me so apologizes in advance if this is
the wrong CL..

[michaelpg, 2017-02-10 00:10:09]

On 2017/02/09 23:41:22, Bret Sepulveda wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/2685883008/ by mailto:bsep@chromium.org.
> 
> The reason for reverting is: Broke compile on Linux x64. Example failure:
>
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...
> 
> The build error is kind of confusing to me so apologizes in advance if this is
> the wrong CL..

Weird. But it does look like the culprit, thanks for the quick revert!

[michaelpg, 2017-02-11 03:01:40]

Description was changed from

==========
Move file_handlers API from //chrome to //extensions

Largely mechanical CL via move_source_file.py, subbing some Profile usage
for BrowserContext.

Results in removing some DEPS exceptions and #includes from //apps.

BUG=679870

Review-Url: https://codereview.chromium.org/2685453002
Cr-Commit-Position: refs/heads/master@{#449460}
Committed:
https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f858...
==========

to

==========
Move file_handlers API from //chrome to //extensions

Largely mechanical CL via move_source_file.py, subbing some Profile usage
for BrowserContext.

Results in removing some DEPS exceptions and #includes from //apps.

BUG=679870

Review-Url: https://codereview.chromium.org/2685453002
Cr-Commit-Position: refs/heads/master@{#449460}
Committed:
https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f858...
==========

[michaelpg, 2017-02-11 03:23:45]

The CQ bit was checked by michaelpg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 03:24:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 05:02:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 05:02:52]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2017-02-13 21:38:08]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-02-13 21:38:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
mtomasz@chromium.org, benwells@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2685453002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-13 21:38:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 23:17:32]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1487021888675620,
"parent_rev": "8e6c60849cd210ebc2e464dd2b8af89dbad0e240", "commit_rev":
"bc6e379f8e228ee5a137e2ee3ff89b973a3494ef"}

[commit-bot: I haz the power, 2017-02-13 23:18:07]

Description was changed from

==========
Move file_handlers API from //chrome to //extensions

Largely mechanical CL via move_source_file.py, subbing some Profile usage
for BrowserContext.

Results in removing some DEPS exceptions and #includes from //apps.

BUG=679870

Review-Url: https://codereview.chromium.org/2685453002
Cr-Commit-Position: refs/heads/master@{#449460}
Committed:
https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f858...
==========

to

==========
Move file_handlers API from //chrome to //extensions

Largely mechanical CL via move_source_file.py, subbing some Profile usage
for BrowserContext.

Results in removing some DEPS exceptions and #includes from //apps.

BUG=679870

Review-Url: https://codereview.chromium.org/2685453002
Cr-Original-Commit-Position: refs/heads/master@{#449460}
Committed:
https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f858...
Review-Url: https://codereview.chromium.org/2685453002
Cr-Commit-Position: refs/heads/master@{#450144}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc6e379f8e228ee5a137e2ee3ff8...
==========

[commit-bot: I haz the power, 2017-02-13 23:18:11]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/bc6e379f8e228ee5a137e2ee3ff8...