[Sync] Fix USS type status counters.

[Sync] Fix USS type status counters.

It seems that NonBlockingTypeDebugInfoEmitter is actually always
invoked when the about-sync page is loaded, not just when the 'Types'
tab is opened. So I've removed the 0 values it emitted, since the other
status counter mechanism through PSS/DTC is always invoked on
about-sync load.

However, the above change didn't completely fix the problem. Instead of
showing 0 for Autofill, I'd see "undefined". This turns out to be
because update/commit counters send the same type of message to the
javascript, but lack num entries in the counters map. It worked out
just fine for Directory types because they'd always send the status
counters after update/commit, but non-blocking types don't have a sync
thread mechanism anymore, and so they cannot take this approach. My fix
is simply don't update in the javascript when num entries are not
defined, so we'll keep the early value from PSS/DTC.

BUG=687013
Review-Url: https://codereview.chromium.org/2666023002
Cr-Commit-Position: refs/heads/master@{#447364}
Committed: https://chromium.googlesource.com/chromium/src/+/9e27208d9936f21f7554396af03c29c508e3d62e

[skym, 2017-01-31 04:08:45]

Description was changed from

==========
[Sync] Fix USS type status counters.

BUG=687013
==========

to

==========
[Sync] Fix USS type status counters.

It seems that NonBlockingTypeDebugInfoEmitter is actually always
invoked when the about-sync page is loaded, not just when the 'Types'
tab is opened. So I've removed the 0 values it emitted, since the other
status counter mechanism through PSS/DTC is always invoked on
about-sync load.

However, the above change didn't completely fix the problem. Instead of
showing 0 for Autofill, I'd see "undefined". This turns out to be
because update/commit counters send the same type of message to the
javascript, but lack num entries in the counters map. It worked out
just fine for Directory types because they'd always send the status
counters after update/commit, but non-blocking types don't have a sync
thread mechanism anymore, and so they cannot take this approach. My fix
is simply don't update in the javascript when num entries are not
defined, so we'll keep the early value from PSS/DTC.

BUG=687013
==========

[skym, 2017-01-31 04:08:45]

skym@chromium.org changed reviewers:
+ gangwu@chromium.org, maxbogue@chromium.org

[skym, 2017-01-31 04:08:54]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2017-01-31 04:09:01]

PTAL

[commit-bot: I haz the power, 2017-01-31 04:09:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 05:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 05:13:34]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2017-01-31 05:33:29]

lgtm but please let Gang review as well.

[Gang Wu, 2017-01-31 21:00:24]

lgtm

[skym, 2017-01-31 23:29:01]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-01-31 23:29:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:37:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485905341786800, "parent_rev":
"1bac2e4aa69d05633b9e8d030d87bfbd08b6b92b", "commit_rev":
"9e27208d9936f21f7554396af03c29c508e3d62e"}

[commit-bot: I haz the power, 2017-01-31 23:38:35]

Description was changed from

==========
[Sync] Fix USS type status counters.

It seems that NonBlockingTypeDebugInfoEmitter is actually always
invoked when the about-sync page is loaded, not just when the 'Types'
tab is opened. So I've removed the 0 values it emitted, since the other
status counter mechanism through PSS/DTC is always invoked on
about-sync load.

However, the above change didn't completely fix the problem. Instead of
showing 0 for Autofill, I'd see "undefined". This turns out to be
because update/commit counters send the same type of message to the
javascript, but lack num entries in the counters map. It worked out
just fine for Directory types because they'd always send the status
counters after update/commit, but non-blocking types don't have a sync
thread mechanism anymore, and so they cannot take this approach. My fix
is simply don't update in the javascript when num entries are not
defined, so we'll keep the early value from PSS/DTC.

BUG=687013
==========

to

==========
[Sync] Fix USS type status counters.

It seems that NonBlockingTypeDebugInfoEmitter is actually always
invoked when the about-sync page is loaded, not just when the 'Types'
tab is opened. So I've removed the 0 values it emitted, since the other
status counter mechanism through PSS/DTC is always invoked on
about-sync load.

However, the above change didn't completely fix the problem. Instead of
showing 0 for Autofill, I'd see "undefined". This turns out to be
because update/commit counters send the same type of message to the
javascript, but lack num entries in the counters map. It worked out
just fine for Directory types because they'd always send the status
counters after update/commit, but non-blocking types don't have a sync
thread mechanism anymore, and so they cannot take this approach. My fix
is simply don't update in the javascript when num entries are not
defined, so we'll keep the early value from PSS/DTC.

BUG=687013

Review-Url: https://codereview.chromium.org/2666023002
Cr-Commit-Position: refs/heads/master@{#447364}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e27208d9936f21f7554396af03c...
==========

[commit-bot: I haz the power, 2017-01-31 23:38:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e27208d9936f21f7554396af03c...