Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2662453008: [Sync] Fix sync lint errors/includes, update presubmit. (Closed)

Created:
3 years, 10 months ago by skym
Modified:
3 years, 10 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix sync lint errors/includes, update presubmit. It seems like lint errors have been sneaking into the sync code base surprisingly quickly. I think it has been in part because the presubmit that runs be default excludes a bunch of filters. I've added a junk filter to their lint call, which should cause things like build/include to always be run. Also fixed all trivial lint errors and includes in sync owned code through running the following commands > find components/sync/ components/sync_bookmarks/ \ components/sync_sessions/ components/browser_sync/ \ chrome/browser/sync/ chrome/browser/ui/sync ios/chrome/browser/sync \ ios/chrome/browser/ui/webui/sync_internals | grep 'cc$\|h$' | xargs \ ../../depot_tools/cpplint.py > tools/remove_duplicate_includes.py components/sync/ \ components/sync_bookmarks/ components/sync_sessions/ \ components/browser_sync/ chrome/browser/sync/ chrome/browser/ui/sync \ ios/chrome/browser/sync ios/chrome/browser/ui/webui/sync_internals BUG= Review-Url: https://codereview.chromium.org/2662453008 Cr-Commit-Position: refs/heads/master@{#447359} Committed: https://chromium.googlesource.com/chromium/src/+/95716a6047eb158be8913623b95deb910be84dcf

Patch Set 1 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -96 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/chrome_sync_client_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extensions_activity_monitor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/migration_waiter.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/multi_client_status_change_checker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_integration_test_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_links_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_observer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/sync_promo_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_sync/PRESUBMIT.py View 1 chunk +6 lines, -1 line 0 comments Download
M components/sync/PRESUBMIT.py View 2 chunks +6 lines, -2 lines 0 comments Download
M components/sync/base/hash_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/base/sync_features.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/device_info/device_info_sync_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/model_type_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/model_type_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine/attachments/fake_attachment_downloader_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/engine/attachments/in_memory_attachment_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/engine/attachments/on_disk_attachment_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine/browser_thread_model_worker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine/browser_thread_model_worker_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine/cycle/sync_cycle_snapshot_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine/engine_components_factory_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/engine/sync_backend_registrar_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine/ui_model_worker_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine_impl/cycle/nudge_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_connection_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server_entity.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/engine_impl/loopback_server/loopback_server_entity.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_bookmark_entity.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_tombstone_entity.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine_impl/test_entry_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/model/fake_model_type_sync_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/model/recording_model_type_change_processor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/model_impl/attachments/task_queue_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/model_impl/model_type_store_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/model_impl/model_type_store_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/protocol/proto_memory_estimations.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync/protocol/proto_value_conversions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_bookmarks/PRESUBMIT.py View 1 chunk +6 lines, -1 line 0 comments Download
M components/sync_sessions/PRESUBMIT.py View 1 chunk +6 lines, -1 line 0 comments Download
M components/sync_sessions/revisit/page_revisit_broadcaster.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_sessions/revisit/page_revisit_broadcaster.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_sessions/synced_tab_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/sync/sync_setup_service.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (14 generated)
skym
PTAL
3 years, 10 months ago (2017-01-31 00:53:01 UTC) #12
maxbogue
lgtm! Imagine if we could detect missing includes for classes outside the std lib...
3 years, 10 months ago (2017-01-31 17:31:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2662453008/80001
3 years, 10 months ago (2017-01-31 23:16:35 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 23:24:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/95716a6047eb158be8913623b95d...

Powered by Google App Engine
This is Rietveld 408576698