Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: components/sync/engine_impl/cycle/non_blocking_type_debug_info_emitter.cc

Issue 2666023002: [Sync] Fix USS type status counters. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/driver/resources/about.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine_impl/cycle/non_blocking_type_debug_info_emitter.cc
diff --git a/components/sync/engine_impl/cycle/non_blocking_type_debug_info_emitter.cc b/components/sync/engine_impl/cycle/non_blocking_type_debug_info_emitter.cc
index 367478446290dffe4e7dfb6fcfe0086b228320c3..a3b5bdf6d667ed5d8d78dbe7ac5686340f261d0e 100644
--- a/components/sync/engine_impl/cycle/non_blocking_type_debug_info_emitter.cc
+++ b/components/sync/engine_impl/cycle/non_blocking_type_debug_info_emitter.cc
@@ -4,11 +4,6 @@
#include "components/sync/engine_impl/cycle/non_blocking_type_debug_info_emitter.h"
-#include <vector>
-
-#include "components/sync/engine/cycle/status_counters.h"
-#include "components/sync/engine/cycle/type_debug_info_observer.h"
-
namespace syncer {
NonBlockingTypeDebugInfoEmitter::NonBlockingTypeDebugInfoEmitter(
@@ -19,14 +14,10 @@ NonBlockingTypeDebugInfoEmitter::NonBlockingTypeDebugInfoEmitter(
NonBlockingTypeDebugInfoEmitter::~NonBlockingTypeDebugInfoEmitter() {}
void NonBlockingTypeDebugInfoEmitter::EmitStatusCountersUpdate() {
- // TODO(gangwu): this function is to show Total Entries on "Types" tab on
- // chrome://sync-internals, we decide to show zero right now, because it is
- // hard to let emitter to get object of SharedModelTypeProcessor or
- // ModelTypeStore, and also people can get the numbers from "about" tab on
- // chrome://sync-internals.
- StatusCounters counters;
- for (auto& observer : *type_debug_info_observers_)
- observer.OnStatusCountersUpdated(type_, counters);
+ // TODO(gangwu): Allow driving emission of status counters from here. This is
+ // tricky because we do not have access to SharedModelTypeProcessor or
+ // ModelTypeStore currently. This method is fairly redundant since counters
+ // are also emitted from the UI thread, unclear how important this is.
}
} // namespace syncer
« no previous file with comments | « components/sync/driver/resources/about.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698