Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2665523002: mash: Use ChromeNativeAppWindowViewsAuraAsh; workaround crashes. (Closed)

Created:
3 years, 10 months ago by msw
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, James Cook
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Use ChromeNativeAppWindowViewsAuraAsh; workaround crashes. Revert the ChromeNativeAppWindowViewsAura workaround. Initialize the views::Widget::InitParams::mus_properties for mash. (set the correct container, display id, and shelf item type) Use ChromeNativeAppWindowViews's NonClientFrameView for panels too. (ash::CustomFrameViewAsh and ash::PanelFrameView are still broken in mash) BUG=679028, 672599 TEST=chrome --mash panel windows are right-aligned. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2665523002 Cr-Commit-Position: refs/heads/master@{#447014} Committed: https://chromium.googlesource.com/chromium/src/+/f49f1ae7c8896402177da53ff27d53be29fcca5c

Patch Set 1 #

Patch Set 2 : Cleanup; fix panel with frame crash. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 7 chunks +35 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
msw
Hey Scott, please take a look, thanks!
3 years, 10 months ago (2017-01-28 01:06:14 UTC) #6
sky
LGTM
3 years, 10 months ago (2017-01-30 16:50:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665523002/20001
3 years, 10 months ago (2017-01-30 17:37:52 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 18:09:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f49f1ae7c8896402177da53ff27d...

Powered by Google App Engine
This is Rietveld 408576698