Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc

Issue 2665523002: mash: Use ChromeNativeAppWindowViewsAuraAsh; workaround crashes. (Closed)
Patch Set: Cleanup; fix panel with frame crash. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/apps/chrome_app_window_client.h" 5 #include "chrome/browser/ui/apps/chrome_app_window_client.h"
6 6
7 #include "chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h " 7 #include "chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h "
8 #include "services/service_manager/runner/common/client_util.h"
9 8
10 // static 9 // static
11 extensions::NativeAppWindow* ChromeAppWindowClient::CreateNativeAppWindowImpl( 10 extensions::NativeAppWindow* ChromeAppWindowClient::CreateNativeAppWindowImpl(
12 extensions::AppWindow* app_window, 11 extensions::AppWindow* app_window,
13 const extensions::AppWindow::CreateParams& params) { 12 const extensions::AppWindow::CreateParams& params) {
14 // TODO: Mash should use ChromeNativeAppWindowViewsAuraAsh, but 13 ChromeNativeAppWindowViewsAuraAsh* window =
15 // it can't because of dependencies on ash. http://crbug.com/679028. 14 new ChromeNativeAppWindowViewsAuraAsh;
16 ChromeNativeAppWindowViewsAura* window =
17 service_manager::ServiceManagerIsRemote()
18 ? new ChromeNativeAppWindowViewsAura
19 : new ChromeNativeAppWindowViewsAuraAsh;
20 window->Init(app_window, params); 15 window->Init(app_window, params);
21 return window; 16 return window;
22 } 17 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698