Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc

Issue 2665523002: mash: Use ChromeNativeAppWindowViewsAuraAsh; workaround crashes. (Closed)
Patch Set: Cleanup; fix panel with frame crash. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc
diff --git a/chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc b/chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc
index 1832d08981b2c2e282edc9c269e3623f8471b07d..289f916e3fb0d7e7e0dbce3ca758b7a23d8949f6 100644
--- a/chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc
+++ b/chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc
@@ -5,18 +5,13 @@
#include "chrome/browser/ui/apps/chrome_app_window_client.h"
#include "chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h"
-#include "services/service_manager/runner/common/client_util.h"
// static
extensions::NativeAppWindow* ChromeAppWindowClient::CreateNativeAppWindowImpl(
extensions::AppWindow* app_window,
const extensions::AppWindow::CreateParams& params) {
- // TODO: Mash should use ChromeNativeAppWindowViewsAuraAsh, but
- // it can't because of dependencies on ash. http://crbug.com/679028.
- ChromeNativeAppWindowViewsAura* window =
- service_manager::ServiceManagerIsRemote()
- ? new ChromeNativeAppWindowViewsAura
- : new ChromeNativeAppWindowViewsAuraAsh;
+ ChromeNativeAppWindowViewsAuraAsh* window =
+ new ChromeNativeAppWindowViewsAuraAsh;
window->Init(app_window, params);
return window;
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698