Chromium Code Reviews
DescriptionFix layout of the sync and sign-in error dialogs when the page zoom is increased.
This CL does the following changes to the sync and sign-in error dialogs:
* Disables the web page zoom as these dialogs should look as native dialogs.
* Uses the document.body.offsetHeight instead of the scrollheight when computing
the preferred size for the dialog's webview as the scrollHeight is different
depending on the page zoom size (the values of the scrollHeight are equal to
offsetHeight / Chrome's page_zoom)
* Display the scrollbars as sometimes the dialog view may be smaller than the
preffered height of the scrollview.
BUG=685021
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2658783004
Cr-Commit-Position: refs/heads/master@{#446848}
(cherry picked from commit 55529d0408f80b154fd394f4f8e1749f5d17329a)
Review-Url: https://codereview.chromium.org/2665113007 .
Cr-Commit-Position: refs/branch-heads/2987@{#245}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/7871dfdba803e497e00d135c8806b310454776fe
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||