Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: chrome/browser/resources/signin/signin_error/signin_error.js

Issue 2665113007: Fix layout of the sync and sign-in error dialogs when the page zoom is increased. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/signin/signin_shared_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/signin/signin_error/signin_error.js
diff --git a/chrome/browser/resources/signin/signin_error/signin_error.js b/chrome/browser/resources/signin/signin_error/signin_error.js
index 0abdaa28604ddb80363444357019ef4b5753c66b..749c99bc03866f9e69ef3baba0627de4db8b3ef6 100644
--- a/chrome/browser/resources/signin/signin_error/signin_error.js
+++ b/chrome/browser/resources/signin/signin_error/signin_error.js
@@ -14,7 +14,11 @@ cr.define('signin.error', function() {
if (loadTimeData.getBoolean('isSystemProfile')) {
$('learnMoreLink').hidden = true;
}
- chrome.send('initializedWithSize', [document.body.scrollHeight]);
+
+ // Prefer using |document.body.offsetHeight| instead of
+ // |document.body.scrollHeight| as it returns the correct height of the
+ // even when the page zoom in Chrome is different than 100%.
+ chrome.send('initializedWithSize', [document.body.offsetHeight]);
}
function onKeyDown(e) {
« no previous file with comments | « no previous file | chrome/browser/resources/signin/signin_shared_css.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698