Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2894)

Unified Diff: chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js

Issue 2665113007: Fix layout of the sync and sign-in error dialogs when the page zoom is increased. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/signin/signin_shared_css.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js
diff --git a/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js b/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js
index 0a08712507f0ef9fdba0307f56219c7fa46a114f..1f51ec8fdb43010694e0794f4dd1b3f3207a0f8b 100644
--- a/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js
+++ b/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js
@@ -28,7 +28,11 @@ cr.define('sync.confirmation', function() {
} else {
$('syncConfirmationDetails').hidden = true;
}
- chrome.send('initializedWithSize', [document.body.scrollHeight]);
+
+ // Prefer using |document.body.offsetHeight| instead of
+ // |document.body.scrollHeight| as it returns the correct height of the
+ // even when the page zoom in Chrome is different than 100%.
+ chrome.send('initializedWithSize', [document.body.offsetHeight]);
}
function clearFocus() {
« no previous file with comments | « chrome/browser/resources/signin/signin_shared_css.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698