DescriptionDo not block in SimpleThread::Start().
There is no good reason to block in SimpleThread::Start().
In addition to introducing unnecessary latency, blocking in
Start() prevents a non-joinable DelegateSimpleThread from
being deleted from Run() without external synchronization
(it is wrong to delete SimpleThread while Start() is waiting
on the |event_| member).
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2664953004
Cr-Commit-Position: refs/heads/master@{#448622}
Committed: https://chromium.googlesource.com/chromium/src/+/8ad2f4f9bb3d55974ea1707ff4186bbe321ea499
Patch Set 1 #Patch Set 2 : fix build error #Patch Set 3 : GetTid() #Patch Set 4 : HasBeenStarted() #
Total comments: 16
Patch Set 5 : CR gab #21 #
Total comments: 2
Patch Set 6 : CR gab #26 (comment) #
Messages
Total messages: 42 (28 generated)
|