Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3734)

Unified Diff: base/win/wait_chain_unittest.cc

Issue 2664953004: Do not block in SimpleThread::Start(). (Closed)
Patch Set: CR gab #26 (comment) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/thread_restrictions.h ('k') | content/renderer/categorized_worker_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/wait_chain_unittest.cc
diff --git a/base/win/wait_chain_unittest.cc b/base/win/wait_chain_unittest.cc
index ba04872206d561234436fc6a344d339bce8727db..5dc6f56f1a41eda5d7d572cb3a8c92eb0c647051 100644
--- a/base/win/wait_chain_unittest.cc
+++ b/base/win/wait_chain_unittest.cc
@@ -109,7 +109,7 @@ class DeadlockThread : public SimpleThread {
// Terminates the thread.
bool Terminate() {
- ScopedHandle thread_handle(::OpenThread(THREAD_TERMINATE, FALSE, tid()));
+ ScopedHandle thread_handle(::OpenThread(THREAD_TERMINATE, FALSE, GetTid()));
return ::TerminateThread(thread_handle.Get(), 0);
}
@@ -259,7 +259,7 @@ TEST(WaitChainTest, Deadlock) {
WaitChainNodeVector wait_chain;
bool is_deadlock;
- ASSERT_TRUE(GetThreadWaitChain(waiting_thread_2->tid(), &wait_chain,
+ ASSERT_TRUE(GetThreadWaitChain(waiting_thread_2->GetTid(), &wait_chain,
&is_deadlock, nullptr, nullptr));
EXPECT_EQ(9U, wait_chain.size());
@@ -298,7 +298,7 @@ TEST(WaitChainTest, CrossProcess) {
WaitChainNodeVector wait_chain;
bool is_deadlock;
- ASSERT_TRUE(GetThreadWaitChain(waiting_thread_3->tid(), &wait_chain,
+ ASSERT_TRUE(GetThreadWaitChain(waiting_thread_3->GetTid(), &wait_chain,
&is_deadlock, nullptr, nullptr));
EXPECT_EQ(7U, wait_chain.size());
« no previous file with comments | « base/threading/thread_restrictions.h ('k') | content/renderer/categorized_worker_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698