Only apply federated matches on HTTPS

Only apply federated matches on HTTPS

Prior to this change federated matches were applied regardless of the scheme.
This change modifies the success condition to that HTTPS is required.

BUG=666340
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2664763002
Cr-Commit-Position: refs/heads/master@{#447001}
Committed: https://chromium.googlesource.com/chromium/src/+/514f1d76b3f3340ff16fde2eb75ff485abee776d

[jdoerrie, 2017-01-30 13:01:17]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 13:01:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-01-30 13:04:12]

Hi Vasilii, please take a look :)

https://codereview.chromium.org/2664763002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_libsecret_unittest.cc
(right):

https://codereview.chromium.org/2664763002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_libsecret_unittest.cc:716:
GURL("https://www.sub.example.com/"),
I missed this during the last CL. Let me know if it's fine to do it here or if
doing this in another CL is preferred.

[vasilii, 2017-01-30 13:29:50]

https://codereview.chromium.org/2664763002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_libsecret_unittest.cc
(right):

https://codereview.chromium.org/2664763002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_libsecret_unittest.cc:716:
GURL("https://www.sub.example.com/"),
On 2017/01/30 13:04:12, jdoerrie wrote:
> I missed this during the last CL. Let me know if it's fine to do it here or if
> doing this in another CL is preferred.

I didn't get why the test is called "FetchPSLMatched". Isn't it an exact match?

[commit-bot: I haz the power, 2017-01-30 13:48:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 13:48:55]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2017-01-30 13:51:39]

https://codereview.chromium.org/2664763002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_libsecret_unittest.cc
(right):

https://codereview.chromium.org/2664763002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_libsecret_unittest.cc:716:
GURL("https://www.sub.example.com/"),
On 2017/01/30 13:29:50, vasilii wrote:
> On 2017/01/30 13:04:12, jdoerrie wrote:
> > I missed this during the last CL. Let me know if it's fine to do it here or
if
> > doing this in another CL is preferred.
> 
> I didn't get why the test is called "FetchPSLMatched". Isn't it an exact
match?

Yeah, you are right. Fixed.

[vasilii, 2017-01-30 14:32:25]

lgtm

[jdoerrie, 2017-01-30 15:53:17]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-01-30 15:53:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 16:48:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485791597787590,
"parent_rev": "656950c2f6ebeae22139d9753eca81f213c74b53", "commit_rev":
"514f1d76b3f3340ff16fde2eb75ff485abee776d"}

[commit-bot: I haz the power, 2017-01-30 16:49:21]

Description was changed from

==========
Only apply federated matches on HTTPS

Prior to this change federated matches were applied regardless of the scheme.
This change modifies the success condition to that HTTPS is required.

BUG=666340
R=vasilii@chromium.org
==========

to

==========
Only apply federated matches on HTTPS

Prior to this change federated matches were applied regardless of the scheme.
This change modifies the success condition to that HTTPS is required.

BUG=666340
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2664763002
Cr-Commit-Position: refs/heads/master@{#447001}
Committed:
https://chromium.googlesource.com/chromium/src/+/514f1d76b3f3340ff16fde2eb75f...
==========

[commit-bot: I haz the power, 2017-01-30 16:49:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/514f1d76b3f3340ff16fde2eb75f...