Only apply federated matches on HTTPS

chrome/browser/password_manager/native_backend_libsecret_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/location.h"
 #include "base/memory/ptr_util.h"
@@ skipping 675 matching lines @@
 TEST_F(NativeBackendLibsecretTest, PSLUpdatingStrictUpdateLogin) {
   CheckPSLUpdate(UPDATE_BY_UPDATELOGIN);
 }
 
 TEST_F(NativeBackendLibsecretTest, PSLUpdatingStrictAddLogin) {
   // TODO(vabr): if AddLogin becomes no longer valid for existing logins, then
   // just delete this test.
   CheckPSLUpdate(UPDATE_BY_ADDLOGIN);
 }
 
-TEST_F(NativeBackendLibsecretTest, FetchFederatedCredential) {
-  other_auth_.signon_realm = "federation://www.example.com/google.com";
-  other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
-  EXPECT_TRUE(CheckCredentialAvailability(other_auth_,
-                                          GURL("http://www.example.com/"),
-                                          PasswordForm::SCHEME_HTML, nullptr));
-}
-
-TEST_F(NativeBackendLibsecretTest, FetchPSLMatchedFederatedCredentialOnHTTPS) {
+TEST_F(NativeBackendLibsecretTest, FetchFederatedCredentialOnHTTPS) {
   other_auth_.signon_realm = "federation://www.example.com/google.com";
   other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
   EXPECT_TRUE(CheckCredentialAvailability(other_auth_,
                                           GURL("https://www.example.com/"),
                                           PasswordForm::SCHEME_HTML, nullptr));
 }
 
-TEST_F(NativeBackendLibsecretTest,
-       DontFetchPSLMatchedFederatedCredentialOnHTTP) {
+TEST_F(NativeBackendLibsecretTest, DontFetchFederatedCredentialOnHTTP) {
   other_auth_.signon_realm = "federation://www.example.com/google.com";
   other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
+  EXPECT_FALSE(CheckCredentialAvailability(other_auth_,
+                                           GURL("http://www.example.com/"),
+                                           PasswordForm::SCHEME_HTML, nullptr));
+}
+
+TEST_F(NativeBackendLibsecretTest, FetchPSLMatchedFederatedCredentialOnHTTPS) {
+  other_auth_.signon_realm = "federation://www.sub.example.com/google.com";
+  other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
   EXPECT_TRUE(CheckCredentialAvailability(other_auth_,
-                                          GURL("http://www.example.com/"),
+                                          GURL("https://www.sub.example.com/"),

[jdoerrie, 2017/01/30 13:04:12]

I missed this during the last CL. Let me know if it's fine to do it here or if
doing this in another CL is preferred.

[vasilii, 2017/01/30 13:29:50]

I didn't get why the test is called "FetchPSLMatched". Isn't it an exact match?

[jdoerrie, 2017/01/30 13:51:38]

Yeah, you are right. Fixed.

                                           PasswordForm::SCHEME_HTML, nullptr));
 }
 
+TEST_F(NativeBackendLibsecretTest,
+       DontFetchPSLMatchedFederatedCredentialOnHTTP) {
+  other_auth_.signon_realm = "federation://www.sub.example.com/google.com";
+  other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
+  EXPECT_FALSE(CheckCredentialAvailability(other_auth_,
+                                           GURL("http://www.sub.example.com/"),
+                                           PasswordForm::SCHEME_HTML, nullptr));
+}
+
 TEST_F(NativeBackendLibsecretTest, BasicUpdateLogin) {
   NativeBackendLibsecret backend(42);
 
   VerifiedAdd(&backend, form_google_);
 
   PasswordForm new_form_google(form_google_);
   new_form_google.times_used = 1;
   new_form_google.action = GURL("http://www.google.com/different/login");
 
   EXPECT_EQ(1u, global_mock_libsecret_items->size());
@@ skipping 262 matching lines @@
   EXPECT_EQ(form_google_, *form_list[0]);
 
   EXPECT_EQ(1u, global_mock_libsecret_items->size());
   if (!global_mock_libsecret_items->empty()) {
     CheckMockSecretItem((*global_mock_libsecret_items)[0].get(), form_google_,
                         "chrome-42");
   }
 }
 
 // TODO(mdm): add more basic tests here at some point.