Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 2664763002: Only apply federated matches on HTTPS (Closed)
Patch Set: Fix Subdomain. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_libsecret_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
index 7080a52bf542ed493b2d1ef8e65f0225d1aca2e7..ed94a38d901922e25126216485f2e96e6e45e1a1 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
@@ -886,14 +886,22 @@ TEST_F(NativeBackendGnomeTest, PSLUpdatingStrictAddLogin) {
CheckPSLUpdate(UPDATE_BY_ADDLOGIN);
}
-TEST_F(NativeBackendGnomeTest, FetchFederatedCredential) {
+TEST_F(NativeBackendGnomeTest, FetchFederatedCredentialOnHTTPS) {
other_auth_.signon_realm = "federation://www.example.com/google.com";
other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
EXPECT_TRUE(CheckCredentialAvailability(other_auth_,
- GURL("http://www.example.com/"),
+ GURL("https://www.example.com/"),
PasswordForm::SCHEME_HTML, nullptr));
}
+TEST_F(NativeBackendGnomeTest, DontFetchFederatedCredentialOnHTTP) {
+ other_auth_.signon_realm = "federation://www.example.com/google.com";
+ other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
+ EXPECT_FALSE(CheckCredentialAvailability(other_auth_,
+ GURL("http://www.example.com/"),
+ PasswordForm::SCHEME_HTML, nullptr));
+}
+
TEST_F(NativeBackendGnomeTest, FetchPSLMatchedFederatedCredentialOnHTTPS) {
other_auth_.signon_realm = "federation://www.sub.example.com/google.com";
other_auth_.federation_origin = url::Origin(GURL("https://google.com/"));
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_libsecret_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698