Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 2664603002: Remove replaceComposition() calls in finishComposingText. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
index fd5cc2adac360f68a24e7040339fe9a1ba02c322..212b16cba6878ca64f967d8bcc38bf40a6f43664 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
@@ -953,7 +953,7 @@ TEST_F(InputMethodControllerTest, CompositionInputEventIsComposing) {
document().title().utf8().data());
document().setTitle(emptyString);
- controller().finishComposingText(InputMethodController::KeepSelection);
+ controller().commitText("bar", underlines, 0);
// Last pair of InputEvent should also be inside composition scope.
EXPECT_STREQ("beforeinput.isComposing:true;input.isComposing:true;",
document().title().utf8().data());
@@ -993,9 +993,7 @@ TEST_F(InputMethodControllerTest, CompositionInputEventForConfirm) {
// Confirm the ongoing composition.
document().setTitle(emptyString);
controller().finishComposingText(InputMethodController::KeepSelection);
- EXPECT_STREQ(
- "beforeinput.data:hello;input.data:hello;compositionend.data:hello;",
- document().title().utf8().data());
+ EXPECT_STREQ("compositionend.data:hello;", document().title().utf8().data());
}
TEST_F(InputMethodControllerTest, CompositionInputEventForDelete) {
« no previous file with comments | « third_party/WebKit/Source/core/editing/InputMethodController.cpp ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698