Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2664603002: Remove replaceComposition() calls in finishComposingText. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 19a2df0f5202b81cd8bbd87c047e4abb23069f1b..1d7a8e4f0045aaccfcc636de709e4f7bc1b66b59 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2298,12 +2298,6 @@ void WebViewImpl::setFocus(bool enable) {
if (focusedFrame) {
// Finish an ongoing composition to delete the composition node.
if (focusedFrame->inputMethodController().hasComposition()) {
- WebAutofillClient* autofillClient =
- WebLocalFrameImpl::fromFrame(focusedFrame)->autofillClient();
-
- if (autofillClient)
- autofillClient->setIgnoreTextChanges(true);
-
// TODO(xiaochengh): The use of
// updateStyleAndLayoutIgnorePendingStylesheets
// needs to be audited. See http://crbug.com/590369 for more details.
@@ -2312,9 +2306,6 @@ void WebViewImpl::setFocus(bool enable) {
focusedFrame->inputMethodController().finishComposingText(
InputMethodController::KeepSelection);
-
- if (autofillClient)
- autofillClient->setIgnoreTextChanges(false);
}
m_imeAcceptEvents = false;
}
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698