MD Settings: Internet: Convert 'Known Networks' page to dropdown menus

MD Settings: Internet: Convert 'Known Networks' page to dropdown menus

BUG=680090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2664383002
Cr-Commit-Position: refs/heads/master@{#447840}
Committed: https://chromium.googlesource.com/chromium/src/+/9279bfbd27957a1d6f23d0b86701dca726b53430

[stevenjb, 2017-02-01 02:47:27]

Description was changed from

==========
MD Settings: Internet: Convert 'Known Networks' page to dropdown menus

BUG=680090
==========

to

==========
MD Settings: Internet: Convert 'Known Networks' page to dropdown menus

BUG=680090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-01 03:03:18]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-02-01 23:43:41]

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
(right):

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.html:24:
<paper-icon-button id="preferredDots" icon="cr:more-vert"
using the same ID in a dom-repeat means the ID would be reused within the
element's shadow root.

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.html:25:
tabindex$="[[tabindex]]" guid$="[[item.GUID]]"
i have a preference for using real attributes. there's a specific HTML feature
for this, data-foo:

    data-guid$="[[item.GUID]]"

which also adds a 'guid' key to the item's |dataset| property.

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.html:38:
<paper-icon-button id="notPreferredDots" icon="cr:more-vert"
ditto

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
(right):

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js:142:
onMenuButtonTap_: function(event) {
opt nit: |e| for consistency

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js:144:
this.selectedGuid_ = button.getAttribute('guid');
button.dataset['guid']

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js:144:
this.selectedGuid_ = button.getAttribute('guid');
actually, I'm already getting rusty, but IIRC |event| should have a |model| for
the item that created this dom-repeat entry.

something like "event.model.item" should be the actual network state object.

[stevenjb, 2017-02-02 01:54:44]

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
(right):

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.html:24:
<paper-icon-button id="preferredDots" icon="cr:more-vert"
On 2017/02/01 23:43:40, michaelpg wrote:
> using the same ID in a dom-repeat means the ID would be reused within the
> element's shadow root.

Yeah, that's a bit weird, I'll use an attribute instead.

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.html:25:
tabindex$="[[tabindex]]" guid$="[[item.GUID]]"
On 2017/02/01 23:43:40, michaelpg wrote:
> i have a preference for using real attributes. there's a specific HTML feature
> for this, data-foo:
> 
>     data-guid$="[[item.GUID]]"
> 
> which also adds a 'guid' key to the item's |dataset| property.

Huh. Interesting. They appear to be available to CSS too. Done.

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.html:38:
<paper-icon-button id="notPreferredDots" icon="cr:more-vert"
On 2017/02/01 23:43:40, michaelpg wrote:
> ditto

Done.

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
(right):

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js:142:
onMenuButtonTap_: function(event) {
On 2017/02/01 23:43:41, michaelpg wrote:
> opt nit: |e| for consistency

I remove the unused 'e' parameters below instead.

https://codereview.chromium.org/2664383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_known_networks_page.js:144:
this.selectedGuid_ = button.getAttribute('guid');
On 2017/02/01 23:43:41, michaelpg wrote:
> actually, I'm already getting rusty, but IIRC |event| should have a |model|
for
> the item that created this dom-repeat entry.
> 
> something like "event.model.item" should be the actual network state object.

Oh, hey, yeah, you're right. Forgot about that, thanks.

[michaelpg, 2017-02-02 19:51:20]

lgtm

[stevenjb, 2017-02-02 19:58:47]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-02-02 19:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 21:19:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486065527781820,
"parent_rev": "166b68a69916dd9c81d2ce58dc3009a701dcb974", "commit_rev":
"9279bfbd27957a1d6f23d0b86701dca726b53430"}

[commit-bot: I haz the power, 2017-02-02 21:20:04]

Description was changed from

==========
MD Settings: Internet: Convert 'Known Networks' page to dropdown menus

BUG=680090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Convert 'Known Networks' page to dropdown menus

BUG=680090
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2664383002
Cr-Commit-Position: refs/heads/master@{#447840}
Committed:
https://chromium.googlesource.com/chromium/src/+/9279bfbd27957a1d6f23d0b86701...
==========

[commit-bot: I haz the power, 2017-02-02 21:20:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9279bfbd27957a1d6f23d0b86701...