Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> | |
| 1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> | 2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> |
| 2 <link rel="import" href="chrome://resources/html/polymer.html"> | 3 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> | 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> |
| 4 <link rel="import" href="/settings_shared_css.html"> | 5 <link rel="import" href="/settings_shared_css.html"> |
| 5 | 6 |
| 6 <dom-module id="settings-internet-known-networks-page"> | 7 <dom-module id="settings-internet-known-networks-page"> |
| 7 <template> | 8 <template> |
| 8 <style include="settings-shared"></style> | 9 <style include="settings-shared"></style> |
| 9 <div class="settings-box first single-column"> | 10 <div class="settings-box first single-column"> |
| 10 <div class="settings-box continuation"> | 11 <div class="settings-box continuation"> |
| 11 <div>$i18n{knownNetworksMessage}</div> | 12 <div>$i18n{knownNetworksMessage}</div> |
| 12 </div> | 13 </div> |
| 13 <div class="settings-box first single-column self-stretch"> | 14 <div class="settings-box first single-column self-stretch"> |
| 14 <div class="secondary">$i18n{knownNetworksPreferred}</div> | 15 <div class="secondary">$i18n{knownNetworksPreferred}</div> |
| 15 <div class="settings-box self-stretch start" | 16 <div class="settings-box self-stretch start" |
| 16 hidden$="[[havePreferred_(networkStateList_)]]"> | 17 hidden$="[[havePreferred_(networkStateList_)]]"> |
| 17 $i18n{knownNetworksNoPreferred} | 18 $i18n{knownNetworksNoPreferred} |
| 18 </div> | 19 </div> |
| 19 <template is="dom-repeat" items="[[networkStateList_]]" | 20 <template is="dom-repeat" items="[[networkStateList_]]" |
| 20 filter="networkIsPreferred_"> | 21 filter="networkIsPreferred_"> |
| 21 <div class="settings-box self-stretch"> | 22 <div class="settings-box self-stretch"> |
| 22 <div class="start">[[item.Name]]</div> | 23 <div class="start">[[item.Name]]</div> |
| 23 <paper-icon-button icon="cr:clear" on-tap="onRemoveTap_"> | 24 <paper-icon-button id="preferredDots" icon="cr:more-vert" |
|
michaelpg
2017/02/01 23:43:40
using the same ID in a dom-repeat means the ID wou
stevenjb
2017/02/02 01:54:44
Yeah, that's a bit weird, I'll use an attribute in
| |
| 25 tabindex$="[[tabindex]]" guid$="[[item.GUID]]" | |
|
michaelpg
2017/02/01 23:43:40
i have a preference for using real attributes. the
stevenjb
2017/02/02 01:54:44
Huh. Interesting. They appear to be available to C
| |
| 26 on-tap="onMenuButtonTap_"> | |
| 24 </paper-icon-button> | 27 </paper-icon-button> |
| 25 </div> | 28 </div> |
| 26 </template> | 29 </template> |
| 27 </div> | 30 </div> |
| 28 <div class="settings-box first single-column self-stretch" | 31 <div class="settings-box first single-column self-stretch" |
| 29 hidden$="[[!haveNotPreferred_(networkStateList_)]]"> | 32 hidden$="[[!haveNotPreferred_(networkStateList_)]]"> |
| 30 <div class="secondary">$i18n{knownNetworksAll}</div> | 33 <div class="secondary">$i18n{knownNetworksAll}</div> |
| 31 <template is="dom-repeat" items="[[networkStateList_]]" | 34 <template is="dom-repeat" items="[[networkStateList_]]" |
| 32 filter="networkIsNotPreferred_"> | 35 filter="networkIsNotPreferred_"> |
| 33 <div class="settings-box self-stretch"> | 36 <div class="settings-box self-stretch"> |
| 34 <div class="start">[[item.Name]]</div> | 37 <div class="start">[[item.Name]]</div> |
| 35 <paper-icon-button icon="cr:add" on-tap="onAddTap_"> | 38 <paper-icon-button id="notPreferredDots" icon="cr:more-vert" |
|
michaelpg
2017/02/01 23:43:40
ditto
stevenjb
2017/02/02 01:54:44
Done.
| |
| 39 tabindex$="[[tabindex]]" guid$="[[item.GUID]]" | |
| 40 on-tap="onMenuButtonTap_"> | |
| 36 </paper-icon-button> | 41 </paper-icon-button> |
| 37 </div> | 42 </div> |
| 38 </template> | 43 </template> |
| 39 </div> | 44 </div> |
| 40 </div> | 45 </div> |
| 46 | |
| 47 <dialog id="dotsMenu" is="cr-action-menu"> | |
| 48 <button class="dropdown-item" role="option" | |
| 49 hidden="[[selectedIsPreferred_]]" on-tap="onAddPreferredTap_"> | |
| 50 $i18n{knownNetworksMenuAddPreferred} | |
| 51 </button> | |
| 52 <button class="dropdown-item" role="option" | |
| 53 hidden="[[!selectedIsPreferred_]]" on-tap="onRemovePreferredTap_"> | |
| 54 $i18n{knownNetworksMenuRemovePreferred} | |
| 55 </button> | |
| 56 <button class="dropdown-item" role="option" on-tap="onForgetTap_"> | |
| 57 $i18n{knownNetworksMenuForget} | |
| 58 </button> | |
| 59 </dialog> | |
| 60 | |
| 41 </template> | 61 </template> |
| 42 <script src="internet_known_networks_page.js"></script> | 62 <script src="internet_known_networks_page.js"></script> |
| 43 </dom-module> | 63 </dom-module> |
| OLD | NEW |