Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

Issue 2664383002: MD Settings: Internet: Convert 'Known Networks' page to dropdown menus (Closed)
Patch Set: Rebase and Feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
index bbd19d2da0cdbedcdee22f47568d16e2ef4ea2ce..bf8b2b3f6f03ce4c4a9d41f5cab0844ac6b98f62 100644
--- a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
@@ -38,6 +38,12 @@ Polymer({
},
},
+ /** @private {string} */
+ selectedGuid_: '',
+
+ /** @private {boolean} */
+ selectedIsPreferred_: false,
+
/**
* Listener function for chrome.networkingPrivate.onNetworksChanged event.
* @type {function(!Array<string>)}
@@ -130,20 +136,34 @@ Polymer({
},
/**
- * @param {!{model: !{item: !CrOnc.NetworkStateProperties}}} e
+ * @param {!Event} event
* @private
*/
- onRemoveTap_: function(e) {
- var state = e.model.item;
- this.networkingPrivate.setProperties(state.GUID, {Priority: 0});
+ onMenuButtonTap_: function(event) {
+ var button = /** @type {!HTMLElement} */ (event.target);
+ this.selectedGuid_ =
+ /** @type {!{model: !{item: !CrOnc.NetworkStateProperties}}} */ (event)
+ .model.item.GUID;
+ this.selectedIsPreferred_ = button.hasAttribute('preferred');
+ /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).showAt(button);
+ event.stopPropagation();
},
- /**
- * @param {!{model: !{item: !CrOnc.NetworkStateProperties}}} e
- * @private
- */
- onAddTap_: function(e) {
- var state = e.model.item;
- this.networkingPrivate.setProperties(state.GUID, {Priority: 1});
+ /** @private */
+ onRemovePreferredTap_: function() {
+ this.networkingPrivate.setProperties(this.selectedGuid_, {Priority: 0});
+ /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
+ },
+
+ /** @private */
+ onAddPreferredTap_: function() {
+ this.networkingPrivate.setProperties(this.selectedGuid_, {Priority: 1});
+ /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
+ },
+
+ /** @private */
+ onForgetTap_: function() {
+ this.networkingPrivate.forgetNetwork(this.selectedGuid_);
+ /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
},
});

Powered by Google App Engine
This is Rietveld 408576698