Reland: mash: Fix MusPropertyMirrorAsh for owned properties; add test.

Reland: mash: Fix MusPropertyMirrorAsh for owned properties; add test.

The original CL (PS1) was reverted for test failures, which I fixed here.
Differences from the the original CL:
-Make ash/public/cpp a component to support exporting symbols
(this allows ash and clients to share window property keys)
(rename cpp component to ash_public_cpp to avoid name conflict)
-Move ShelfItem back to ash/common/shelf (shouldn't be used externally)
-Move the shelf item types into ash/public/cpp/shelf_types.h
-TODO: rename ash/common/shelf/shelf_item_types.* to shelf_item.*

Modified Original Description:

mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.
Remove the ShelfID mirroring (this prop hopefully shouldn't be needed)

Fallout from move to ash/public/cpp:
-Move some shelf_item_types.h to ash/public/cpp/shelf_types.h
-Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
-Move two mirrored ash window properties to ash/public/cpp

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2669633003
Cr-Commit-Position: refs/heads/master@{#447455}
Committed: https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7d6ae4f2c9c83

patch from issue 2669633003 at patchset 100001 (http://crrev.com/2669633003#ps100001)

Review-Url: https://codereview.chromium.org/2664113004
Cr-Commit-Position: refs/heads/master@{#447819}
Committed: https://chromium.googlesource.com/chromium/src/+/8329bfa3d93c3e5cd84a82268500af6989f157f3

[msw, 2017-02-01 21:46:26]

Description was changed from

==========
Reland: mash: Fix MusPropertyMirrorAsh for owned properties; add test.

The original CL was reverted for test failures.
Original Description:

mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.

Fallout from move to ash/public/cpp:
-Move shelf_item_types.* to ash/public/cpp
(TODO: remove stub header used for temporary forwarding)
-Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
-Move two mirrored ash window properties to ash/public/cpp

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2669633003
Cr-Commit-Position: refs/heads/master@{#447455}
Committed:
https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7...

patch from issue 2669633003 at patchset 100001
(http://crrev.com/2669633003#ps100001)
==========

to

==========
Reland: mash: Fix MusPropertyMirrorAsh for owned properties; add test.

The original CL (PS1) was reverted for test failures, which I fixed here.
Differences from the the original CL:
-Make ash/public/cpp a component to support exporting symbols
(this allows ash and clients to share window property keys)
(rename cpp component to ash_public_cpp to avoid name conflict)
-Move ShelfItem back to ash/common/shelf (shouldn't be used externally)
-Move the shelf item types into ash/public/cpp/shelf_types.h
-TODO: rename ash/common/shelf/shelf_item_types.* to shelf_item.*

Modified Original Description:

mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.
Remove the ShelfID mirroring (this prop hopefully shouldn't be needed)

Fallout from move to ash/public/cpp:
-Move some shelf_item_types.h to ash/public/cpp/shelf_types.h
-Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
-Move two mirrored ash window properties to ash/public/cpp

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2669633003
Cr-Commit-Position: refs/heads/master@{#447455}
Committed:
https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7...

patch from issue 2669633003 at patchset 100001
(http://crrev.com/2669633003#ps100001)
==========

[msw, 2017-02-01 21:46:34]

Patchset #2 (id:20001) has been deleted

[msw, 2017-02-01 21:46:41]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 21:46:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 21:49:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 21:49:04]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msw, 2017-02-01 21:58:40]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 21:59:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-02-01 22:20:54]

Hey Scott, please take a look; thanks!

[sky, 2017-02-01 22:49:23]

LGTM

[commit-bot: I haz the power, 2017-02-01 23:39:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 23:39:24]

Dry run: This issue passed the CQ dry run.

[msw, 2017-02-02 00:11:55]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:12:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 00:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:22:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2017-02-02 00:25:23]

msw@chromium.org changed reviewers:
+ reveman@chromium.org, tsepez@chromium.org

[msw, 2017-02-02 00:25:24]

+tsepez@ for ash/public/interfaces/OWNERS
+reveman@ for components/exo/OWNERS
please take a look (dep target rename), thanks!

[reveman, 2017-02-02 02:41:53]

components/exo lgtm

[Tom Sepez, 2017-02-02 18:44:22]

OWNERS LGTM

[msw, 2017-02-02 19:23:51]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-02-02 19:24:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 19:34:57]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486063431321640,
"parent_rev": "bad0c9bef8ad8e784f0ea7e51e1cd341f1712c84", "commit_rev":
"8329bfa3d93c3e5cd84a82268500af6989f157f3"}

[commit-bot: I haz the power, 2017-02-02 19:35:50]

Description was changed from

==========
Reland: mash: Fix MusPropertyMirrorAsh for owned properties; add test.

The original CL (PS1) was reverted for test failures, which I fixed here.
Differences from the the original CL:
-Make ash/public/cpp a component to support exporting symbols
(this allows ash and clients to share window property keys)
(rename cpp component to ash_public_cpp to avoid name conflict)
-Move ShelfItem back to ash/common/shelf (shouldn't be used externally)
-Move the shelf item types into ash/public/cpp/shelf_types.h
-TODO: rename ash/common/shelf/shelf_item_types.* to shelf_item.*

Modified Original Description:

mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.
Remove the ShelfID mirroring (this prop hopefully shouldn't be needed)

Fallout from move to ash/public/cpp:
-Move some shelf_item_types.h to ash/public/cpp/shelf_types.h
-Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
-Move two mirrored ash window properties to ash/public/cpp

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2669633003
Cr-Commit-Position: refs/heads/master@{#447455}
Committed:
https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7...

patch from issue 2669633003 at patchset 100001
(http://crrev.com/2669633003#ps100001)
==========

to

==========
Reland: mash: Fix MusPropertyMirrorAsh for owned properties; add test.

The original CL (PS1) was reverted for test failures, which I fixed here.
Differences from the the original CL:
-Make ash/public/cpp a component to support exporting symbols
(this allows ash and clients to share window property keys)
(rename cpp component to ash_public_cpp to avoid name conflict)
-Move ShelfItem back to ash/common/shelf (shouldn't be used externally)
-Move the shelf item types into ash/public/cpp/shelf_types.h
-TODO: rename ash/common/shelf/shelf_item_types.* to shelf_item.*

Modified Original Description:

mash: Fix MusPropertyMirrorAsh for owned properties; add test.

I fixed gfx::ImageSkia in: https://codereview.chromium.org/2667743003
This CL fixes the owned string properties similarly.
Move the ash mirror to it's own file; add mash_unittest fixtures.
Remove the ShelfID mirroring (this prop hopefully shouldn't be needed)

Fallout from move to ash/public/cpp:
-Move some shelf_item_types.h to ash/public/cpp/shelf_types.h
-Move kInvalidShelfID to avoid moving shelf_constants.h (better home)
-Move two mirrored ash window properties to ash/public/cpp

BUG=686936
TEST=automated; no crashes running apps on chrome --mash.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2669633003
Cr-Commit-Position: refs/heads/master@{#447455}
Committed:
https://chromium.googlesource.com/chromium/src/+/612e45de4250e73fa0df767121d7...

patch from issue 2669633003 at patchset 100001
(http://crrev.com/2669633003#ps100001)

Review-Url: https://codereview.chromium.org/2664113004
Cr-Commit-Position: refs/heads/master@{#447819}
Committed:
https://chromium.googlesource.com/chromium/src/+/8329bfa3d93c3e5cd84a82268500...
==========

[commit-bot: I haz the power, 2017-02-02 19:35:51]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8329bfa3d93c3e5cd84a82268500...