DescriptionReland of Use full viewport height for layout if URL bar is locked shown or hidden. (patchset #1 id:1 of https://codereview.chromium.org/2657773005/ )
Reason for revert:
Relanding since the graph in the original bug didn't get any better, ruling out this CL.
Original issue's description:
> Revert of Use full viewport height for layout if URL bar is locked shown or hidden. (patchset #2 id:20001 of https://codereview.chromium.org/2614993002/ )
>
> Reason for revert:
> Temporarily reverting to see if it fixes the memory regression in the linked bug.
> BUG=679546
>
> Original issue's description:
> > Use full viewport height for layout if URL bar is locked shown or hidden.
> >
> > With inert-top-controls turned on by default, we don't change the layout height
> > when the top controls are normally hidden. That is, if a user hides the URL bar
> > by scrolling, the page won't resize to use the newly available space. It'll lay
> > out as though the URL bar was still showing.
> >
> > This patch makes an exception for cases where Chrome locks the URL bar in the
> > hidden state. e.g. Fullscreen or WebApp mode. In those cases, since the URL bar
> > can't be shown at all, there's no reason not to use the full height.
> >
> > BUG=678649
> >
> > Review-Url: https://codereview.chromium.org/2614993002
> > Cr-Commit-Position: refs/heads/master@{#441995}
> > Committed: https://chromium.googlesource.com/chromium/src/+/18940be9f2a3912efbdbed71863a7749ed243e9a
>
> TBR=aelias@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=678649
>
> Review-Url: https://codereview.chromium.org/2657773005
> Cr-Commit-Position: refs/heads/master@{#446693}
> Committed: https://chromium.googlesource.com/chromium/src/+/01f12135d93ddd4f3daf304f8a3b86c4cd7c6dbe
TBR=aelias@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=679546
Review-Url: https://codereview.chromium.org/2663823002
Cr-Commit-Position: refs/heads/master@{#447155}
Committed: https://chromium.googlesource.com/chromium/src/+/9427bfd430073a9caa0770ab6653b040520a8aab
Patch Set 1 #
Messages
Total messages: 10 (5 generated)
|