Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2657773005: Revert of Use full viewport height for layout if URL bar is locked shown or hidden. (Closed)

Created:
3 years, 10 months ago by bokan
Modified:
3 years, 10 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use full viewport height for layout if URL bar is locked shown or hidden. (patchset #2 id:20001 of https://codereview.chromium.org/2614993002/ ) Reason for revert: Temporarily reverting to see if it fixes the memory regression in the linked bug. BUG=679546 Original issue's description: > Use full viewport height for layout if URL bar is locked shown or hidden. > > With inert-top-controls turned on by default, we don't change the layout height > when the top controls are normally hidden. That is, if a user hides the URL bar > by scrolling, the page won't resize to use the newly available space. It'll lay > out as though the URL bar was still showing. > > This patch makes an exception for cases where Chrome locks the URL bar in the > hidden state. e.g. Fullscreen or WebApp mode. In those cases, since the URL bar > can't be shown at all, there's no reason not to use the full height. > > BUG=678649 > > Review-Url: https://codereview.chromium.org/2614993002 > Cr-Commit-Position: refs/heads/master@{#441995} > Committed: https://chromium.googlesource.com/chromium/src/+/18940be9f2a3912efbdbed71863a7749ed243e9a TBR=aelias@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=678649 Review-Url: https://codereview.chromium.org/2657773005 Cr-Commit-Position: refs/heads/master@{#446693} Committed: https://chromium.googlesource.com/chromium/src/+/01f12135d93ddd4f3daf304f8a3b86c4cd7c6dbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -99 lines) Patch
M third_party/WebKit/Source/core/frame/BrowserControls.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 4 chunks +6 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bokan
Created Revert of Use full viewport height for layout if URL bar is locked shown ...
3 years, 10 months ago (2017-01-27 15:28:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657773005/1
3 years, 10 months ago (2017-01-27 15:28:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/01f12135d93ddd4f3daf304f8a3b86c4cd7c6dbe
3 years, 10 months ago (2017-01-27 17:02:29 UTC) #6
bokan
3 years, 10 months ago (2017-01-30 17:28:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2663823002/ by bokan@chromium.org.

The reason for reverting is: Relanding since the graph in the original bug
didn't get any better, ruling out this CL..

Powered by Google App Engine
This is Rietveld 408576698