Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Issue 2614993002: Use full viewport height for layout if URL bar is locked shown or hidden. (Closed)

Created:
3 years, 11 months ago by bokan
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use full viewport height for layout if URL bar is locked shown or hidden. With inert-top-controls turned on by default, we don't change the layout height when the top controls are normally hidden. That is, if a user hides the URL bar by scrolling, the page won't resize to use the newly available space. It'll lay out as though the URL bar was still showing. This patch makes an exception for cases where Chrome locks the URL bar in the hidden state. e.g. Fullscreen or WebApp mode. In those cases, since the URL bar can't be shown at all, there's no reason not to use the full height. BUG=678649 Review-Url: https://codereview.chromium.org/2614993002 Cr-Commit-Position: refs/heads/master@{#441995} Committed: https://chromium.googlesource.com/chromium/src/+/18940be9f2a3912efbdbed71863a7749ed243e9a

Patch Set 1 #

Patch Set 2 : na #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -8 lines) Patch
M third_party/WebKit/Source/core/frame/BrowserControls.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 4 chunks +16 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
bokan
ptal
3 years, 11 months ago (2017-01-05 16:38:56 UTC) #4
aelias_OOO_until_Jul13
lgtm
3 years, 11 months ago (2017-01-06 02:00:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614993002/20001
3 years, 11 months ago (2017-01-06 15:40:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/18940be9f2a3912efbdbed71863a7749ed243e9a
3 years, 11 months ago (2017-01-06 18:53:50 UTC) #13
bokan
3 years, 10 months ago (2017-01-27 15:28:01 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2657773005/ by bokan@chromium.org.

The reason for reverting is: Temporarily reverting to see if it fixes the memory
regression in the linked bug.
BUG=679546.

Powered by Google App Engine
This is Rietveld 408576698